Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian portable should use a newer dockerfile to build portable images #13079

Closed
3 tasks
mmitche opened this issue Jan 19, 2022 · 2 comments
Closed
3 tasks

Debian portable should use a newer dockerfile to build portable images #13079

mmitche opened this issue Jan 19, 2022 · 2 comments

Comments

@mmitche
Copy link
Member

mmitche commented Jan 19, 2022 •
edited by baronfel
Loading

79bf940 updated from 16.04 to 18.04 for build images. This was a positive change, but the 18.04 dockerfile is missing debuild. Attempting to install this using the same method on 18.04 (https://github.com/dotnet/installer/blob/main/eng/docker/ubuntu.16.04/Dockerfile#L25-L29) doesn't appear to do the right thing.

After fixing this, the following should be true:

  • The build should not fail silently if it can't build deb packages in official builds
  • We should be using newer than 16.04 for the docker container.
  • This should be the case for main, 6.0.1xx, 6.0.2xx, 5.0.2xx and 5.0.4xx
mmitche added a commit to mmitche/installer that referenced this issue Jan 19, 2022
@mmitche
Revert back to 16.04 dockerfile temporarily
4bb2546 
The 18.04 dockerfile is missing some required tooling necessary to build the debian images packages. This tooling is installed in the 16.04 dockerfile, but it appears that the same attempts to install this in 18.04 fail. Until this is resolved, avoid using the 18.04 image.
dotnet#13079
mmitche added a commit to mmitche/installer that referenced this issue Jan 19, 2022
@mmitche
Revert back to 16.04 dockerfile temporarily
9fc6975 
The 18.04 dockerfile is missing some required tooling necessary to build the debian images packages. This tooling is installed in the 16.04 dockerfile, but it appears that the same attempts to install this in 18.04 fail. Until this is resolved, avoid using the 18.04 image.
dotnet#13079
This was referenced Jan 19, 2022
Merged
Merged
@mmitche mmitche changed the title 5.0.2xx and 5.0.4xx should use a newer dockerfile to build portable images Debian portable should use a newer dockerfile to build portable images Jan 19, 2022
mmitche added a commit to mmitche/installer that referenced this issue Feb 25, 2022
@mmitche
Revert back to 16.04 dockerfile temporarily
93f3e91 
The 18.04 dockerfile is missing some required tooling necessary to build the debian images packages. This tooling is installed in the 16.04 dockerfile, but it appears that the same attempts to install this in 18.04 fail. Until this is resolved, avoid using the 18.04 image.
dotnet#13079
@mmitche mmitche mentioned this issue Feb 25, 2022
Merged
mmitche added a commit that referenced this issue Feb 25, 2022
@mmitche
Revert back to 16.04 dockerfile temporarily (#13283)
a8dae49 
The 18.04 dockerfile is missing some required tooling necessary to build the debian images packages. This tooling is installed in the 16.04 dockerfile, but it appears that the same attempts to install this in 18.04 fail. Until this is resolved, avoid using the 18.04 image.
#13079
@marcpopMSFT
Copy link
Member

Docker files are removed in main: #14541
@mmitche was there more to do in servicing for this?

@MiYanni
Copy link
Member

MiYanni commented Jun 10, 2024

Triage: Closing as we're not longer using dockerfiles for containers. Any changes to the containers can take place in dotnet/sdk.

@MiYanni MiYanni closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mmitche @marcpopMSFT @MiYanni