The separate fsharp.core.optdata files and fsharp.core.sigdata files are no longer necessary #9852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Aug 1, 2020
KevinRansom
changed the title
brettfo
approved these changes
Aug 3, 2020
|
Is there any reason it's not merged to |
|
Yes, this should probably have gone in the master first unless i'm mistaken. Will need to do a cherry pack back over I guess |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing these two files from the FSharp.Core.nuget package. The compiler no longer needs access to these loose files. They are embedded in the compiler and have been since Visual Studio 2015.
Also, we should stop deploying them with the VS tooling.