Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new language features for F# 5.0 #9827

Merged
merged 5 commits into from
Aug 12, 2020

Conversation

KevinRansom
Copy link
Member

KevinRansom commented 20 minutes ago
We have done final reviews for these features and are confident they are ready for F# 5.0

    LanguageFeature.OpenStaticClasses, languageVersion50
    LanguageFeature.PackageManagement, languageVersion50
    LanguageFeature.WitnessPassing, languageVersion50
    LanguageFeature.InterfacesWithMultipleGenericInstantiation, languageVersion50
    LanguageFeature.NameOf, languageVersion50

We will address remaining issues and updates as bug fixes.
The InterpolatedStrings and Slicing features will be reviewed before RTM in order to consider inclusion in F# 5.0

Kevin

Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but let's wait till we get all the nameof and open type updates in first.

@smoothdeveloper
Copy link
Contributor

@KevinRansom, regarding LanguageFeature.PackageManagement, I've given a shot to most recent dotnet core and VS2019 previews, and was able to make it work with paket implementation, although I've not yet looked into details about the number of calls being made (which came in discussion in a PR from you about how the lines are commited for evaluation).

There is still one thing I'm not able to get working, which is integrating the similar usage through FSharp.Compiler.Service APIs, I was looking at getting a typed AST and compiled assembly from in-memory code buffer.

After some testing there, ParseAndCheckFileInProject and CompileToDynamicAssembly don't seem to activate the path with dependency manager, although for the first call, I'm passing /langversion:preview as an option.

Is there anything pending on this area or pointers that would help me figure out what I'm missing?

Also, one thing which seems missing in FCS is ability to pass compiler flags or "project options" to the CompileToDynamicAssembly, but maybe I'm overlooking the proper usage.

@KevinRansom
Copy link
Member Author

@smoothdeveloper , if you can put together a small repro, I will take a look. However, what used to work should still work. I haven't really done anything that should break existing code paths.

@KevinRansom KevinRansom merged commit 9156636 into dotnet:release/dev16.8 Aug 12, 2020
@KevinRansom KevinRansom deleted the updatefsharp5 branch October 29, 2020 18:58
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Update to fsharp5

* Update preview error messages

* Update error messages

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants