[RFC FS-1001] String Interpolation #8907

dsyme · 2020-04-08T15:03:34Z

Replaces #6770 by using a feature branch instead

As part of this, I did a signficant cleanup and simplification to printf.fs. At first I thought this wasn't going to be necessary but in the end it was.

Remove over 300 lines from the implementation
Much simpler representation of the results of parsing the format string as a set of steps. When the string is commited to an environment the steps are iterated and interpreted.
This replaces the very complex use of closures (with the same or better efficiency), and makes it possible to use the interpretation of steps for the case where the arguments are captured in the format string by printfn "$abc {1} def"
For numeric formatters the use of complex inlined generic arithmetic code is removed in favour of code that works over type obj. Presumably this reduces the overall IL codegen for the file too.
careful commenting, naming and formatting of code to improve readability
move some unit tests to FSharp.COmpiler.UnitTests to make them cross-platform and help us iterate on them faster (fewer dependencies)

Our tests are extremely good for printf so I'm confident that the coverage is tight.

DONE:

Language testing:

Quotations of interpolations
Quotations in interpolations
Object expressions in interpolations
Exception handling in interpolations
Check errors for end-of-file incomplete strings

IDE Tooling manual testing:

Manually check colorization works as you'd expect it inside of an interpolation context
BUG: interpolation for multi-line interpolation strings (fixed)
Manually check tooltips work as you'd expect it inside of an interpolation context
Manually check completion works as you'd expect it inside of an interpolation context
Manually check go-to-definition works as you'd expect it inside of an interpolation context
Manually check you can set breakpoints in the interpolation context
It would be good to also manually check you can debug when compiled with an interpolated string, but preview tooling doesn't really allow compilation and launch from VS. I am pretty certain this is ok, the breakpoints set ok and the rest is up to the runtime engine

Unit testing:

classification of tokens for various strings
completion works as you'd expect it inside of an interpolation context
go-to-definition works as you'd expect it inside of an interpolation context
automatic brace matching
colorization of format specifiers (%d{...})

Out of scope:

automatic brace completion : note: Roslyn doesn't seem to allow this to be triggered

See #6770 for initial notes by @yatli

dsyme · 2020-04-08T19:52:51Z

I have pushed the rest of the implementation of this feature to "rough prototype" level:

System.Console.WriteLine $"this is 2"
System.Console.WriteLine $"this is {1} = 2"
System.Console.WriteLine $"this is {1} + {1+1} = 3"
System.Console.WriteLine $"this is %d{1} + {1+1+3} = 6"
//System.Console.WriteLine $"this is %s{2} + {1+1} = 4" // correctly gives type checking error

let x = 12
System.Console.WriteLine $"this is 0x%08x{x} + {1+1} = 14"
let s = "sixsix"
System.Console.WriteLine $"this is {s.Length} + {1+1} = 8"

gives

this is 2
this is 1 = 2
this is 1 + 2 = 3
this is 1 + 5 = 6
this is 0x0000000c + 2 = 14
this is 6 + 2 = 8

The feature feels really, really nice to use, I love the unification between printf formats and interpolation! I can reuse all my knowledge about the former, but still use the latter, and ther result is still lovely strongly typed.

I'm going to take a break for the eveing - if anyone would like to start using this and pasting in more test cases please do.

abelbraaksma · 2020-04-09T15:40:48Z

Wow, so many thumbs up, hearts etc in less than a day, feels like the whole F# community was very eager to see this revived! 💯

Happypig375 · 2020-04-09T15:42:35Z

Maybe someone shared it and went viral lol

dsyme · 2020-04-09T18:03:58Z

I've updated the implementation with some preliminary testing and a bunch of fixes

dsyme · 2020-04-09T18:16:12Z

I've been over the RFC and noted what is and isn't supported in the notes up at the top of this PR.

Swoorup · 2020-04-15T01:08:21Z

Is there a way I can test this feature online? I can't sign in to azure

cartermp · 2020-04-15T02:02:53Z

@swaroop-sridhar there's no need to sign into Azure for anything. Just building from this repo is sufficient.

swaroop-sridhar · 2020-04-15T02:14:17Z

@cartermp you probably meant to tag @Swoorup.

smoothdeveloper · 2020-04-15T02:19:11Z

@cartermp, is there anyway to get some of the experimental branches to show up on https://sharplab.io/ to enable the same way you can pick experimental C# compilers there?

I'm sure this will help more people testing preview features even before they land into a shipped version of the compiler.

…e/string-interp

yatli · 2020-04-15T12:35:29Z

A bit off-topic, I'm trying to set up my dev env (language server etc.) but the language server doesn't fully understand the custom build rules, and gives an error: Failed to build FSharp.Core.fsproj: Could not load project /home/yatli/git/fsharp/src/fsharp/FSharp.Core/FSharp.Core.fsproj in ProjectCollection. Available tools: ["/home/yatli/.config/coc/extensions/coc-fsharp-data/server"; "/usr/share/dotnet/sdk/3.1.201"]. ToolsVersion: Current. Message: The SDK 'Microsoft.DotNet.Arcade.Sdk' specified could not be found. /home/yatli/git/fsharp/FSharpBuild.Directory.Build.props

I remember started having this problem when the repo switched to arcade.
Any suggestions?

dsyme · 2020-04-15T13:22:39Z

@yatli I'm really sorry, I don't know, I've not seen that error

yatli · 2020-04-15T13:47:57Z

@dsyme no problem at all! I'm still ramping up and I will find a way.

dsyme · 2020-04-15T17:40:24Z

This draft is complete apart from negative testing and performance testing.

dbrattli · 2020-04-16T06:57:22Z

What is btw the story for nested string interpolation? E.g

> let a = $"""test{$"ing"}""";; 
val a : string = "testing"

works, but not with {}:

> let ing = "ing";;             
val ing : string = "ing"

> let a = $"""test{$"{ing}"}""";; 

  let a = $"""test{$"{ing}"}""";; 
  -----------------------^

/Users/dbrattli/Developer/Github/fsharp/artifacts/bin/fsi/Debug/netcoreapp3.0/stdin(9,24): error FS0010: Unexpected symbol '}' in binding. Expected interpolated string (final part), interpolated string (part) or other token.

Is it supposed to work? Do I need to escape the inner {} in any way?

yatli · 2020-04-16T09:33:51Z

Updated my language server implementation a bit. It sort of type-checks now :)
Working on test cases.

btw I see currently the interpolated string is hard-coded to have different isInterp flag than printf formatters.

Should we allow printfn $""? Currently the typecheck fails with "string incompatible with formatter", but then printfn "" works.
Should we allow mixed interp-noninterp usage?

abelbraaksma · 2020-04-16T16:08:18Z

Is it supposed to work? Do I need to escape the inner {} in any way?

@yatli yes, it's supposed to, at least if I compare with the c# docs.

See also my comment here, and the one below that from @cartermp: fsharp/fslang-design#368 (comment)

dsyme · 2020-04-16T17:15:53Z

@abelbraaksma @yatli Actually I do think both of these should work (but don't right now):

let a = $"""test{$"{ing}"} """
let a = $"test{$"{ing}"} ";;

I'm not sure what the problem is. THis works:

let a = $" {$"a"} ";;

but this doesn;t:

let a = $" {$"a{1}"} ";;

dsyme · 2020-08-05T16:24:44Z

@cartermp are there any more changes you would like us to make here?

cartermp · 2020-08-05T16:28:51Z

Nothing that can't be done incrementally.

dsyme · 2020-08-05T16:48:02Z

Nothing that can't be done incrementally.

Cool, can you approve? I think it's listed as changes requested?

cartermp

Sorry - had a block on here from before the design review + changes to tools that make this work well.

…interp Merge master to feature/string-interp

KevinRansom

Nothing, that must be changed, the stringtype is a bunch of magic values, perhaps we can consider a pr turning them into flags or enums, so they have decent names.

src/fsharp/FSharp.Core/printf.fs

KevinRansom · 2020-08-06T20:36:43Z

src/fsharp/service/ServiceLexing.fs

            ifdefStackCount <- ifdefStackCount + 1

+        let stringKindValue =


Magic values, it would be nice if these were an enum or flags.

KevinRansom · 2020-08-06T20:36:57Z

src/fsharp/service/ServiceLexing.fs

+                match rest with 
+                | [] -> false, 0, 0
+                | (i2, kind2, _)::_ -> true, i2, encodeStringStyle kind2
+            (if tag1 then      0b100000000000 else 0) |||


Magic values, it would be nice if these were an enum or flags.

KevinRansom · 2020-08-06T20:37:21Z

src/fsharp/service/ServiceLexing.fs


+        let stringKindValue = int32 ((bits &&& stringKindMask) >>> stringKindStart)
+        let stringKind : LexerStringKind =


Magic values, it would be nice if these were an enum or flags.

abelbraaksma · 2020-08-06T22:52:39Z

For anybody wanting to play around with the latest build of this feature (esp. those that aren't aware how to do this and are curious where to start):

Checkout this feature branch (feature/string-interp)
Build by running build.cmd (if you already had a build before switching branches, use git clean -xdf first)
Open VisualFSharp.sln, select Release and Build All
Select VisualFSharpFull as startup project, hit Ctrl-F5

A new VS instance is started with the new features selected, but when you create a project, it will, by default, reference an FSharp.Core.dll from NuGet. To fix this:

Open your test fsproj file and add a line <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference> in the top property group
In the same property group, add <LangVersion>preview</LangVersion>
OR: In the same property group, add <OtherFlags>--langversion:preview</OtherFlags>
Add a standard file assembly reference to [fsharp-checkoutdir]\artifacts\bin\VisualFSharpFull\Release\net472\FSharp.Core.dll

A minimal project file for netcoreapp3.1 could look something like this:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
    <LangVersion>preview</LangVersion>
    <!-- the previous, OR the following line -->
    <OtherFlags>--langversion:preview</OtherFlags>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
	<WarningsAsErrors>3239;25</WarningsAsErrors>
  </PropertyGroup>

  <ItemGroup>
    <Compile Include="Program.fs" />
  </ItemGroup>

  <ItemGroup>
    <Reference Include="FSharp.Core">
      <HintPath>D:\Projects\OpenSource\FSharp\artifacts\bin\VisualFSharpFull\Release\net472\FSharp.Core.dll</HintPath>
    </Reference>
  </ItemGroup>
</Project>

Now you can start typing your code without errors along the line of "Feature 'string interpolation' requires the F# library for language version 4.7 or greater." (an error you will also get if your project actually references 4.7.0, but that's a bug for another time, or maybe I just screwed something up locally).

abelbraaksma · 2020-08-07T00:12:13Z

@dsyme, I think I found one serious bug (half the expressions are not evaluated sometimes). I reported it separately so that I can update the issue if I find more stuff, and I don't delay this thread too much. Please see: #9893.

dsyme · 2020-08-07T00:16:51Z

@dsyme, I think I found one serious bug (half the expressions are not evaluated sometimes). I reported it separately so that I can update the issue if I find more stuff, and I don't delay this thread too much. Please see: #9893.

Thanks, I'll be working on fixes for these right now :-)

dsyme · 2020-08-07T01:57:39Z

@dsyme, I think I found one serious bug (half the expressions are not evaluated sometimes). I reported it separately so that I can update the issue if I find more stuff, and I don't delay this thread too much. Please see: #9893.

Both of the two serious issues from #9893 have been fixed

missed inputs for neighbouring interpolations $"{0}{1}{2}"
no check for unmatched } in an interpolated string, it was going through as text.

KevinRansom · 2020-08-07T03:18:01Z

Thank you Don

realvictorprm · 2020-08-07T11:51:54Z

This is great news!

dsyme · 2020-08-07T12:31:05Z

@realvictorprm This is great news!

Yes it is!!

abelbraaksma · 2020-08-07T12:41:06Z

We should open that champagne bottle to celebrate we got rfc #1 of the todo list! There's a lot of hidden beauty in this feature :) 🍾 🍾

adelarsq · 2020-08-07T12:42:23Z

Lets the fun begin! Thank you all for the work on this! 🎉🚀

* string interploation implementation * string interploation tests * escape {{ }}, test verbatim and triple quote, implement .NET specifiers * fix tests * string interpolation tests: internal representation corner cases * string-interp tests should have --langversion:preview * string interop tests: sprintf * string interp tests: format specifier negative cases * string interp tests: format specifier negative cases, .NET-style padding * fix nested interp strings * style cleanup * lex: unify string interp stack and counter * string-interp: add test cases * fix mixed quote nested string interpolation * string-interp: add test case for multiple interpolation points with different indentation * lexfilter: push new CtxtParen at endPos for INTERP_STRING_PART and INTERP_STRING_BEGIN_PART * lexfilter: do not check undentation limit for string interpolation tokens. * FormattableString prototype * add FormattableString support * negative error checking * remove diagnostics * simpler FormattableString implementation * fix test * add testing for nested * add IFormattable support * tweak error message * tests: StringInterpolation: fix case errors * fix error message * check number of values matches * allow use of format strings with printf and friends * update baselines * fix baselines * add Experimental attributes * update string interp negative tests * stringinterp test: add PrintFormat tests * printf: fix empty interpolation string evaluates to null in printf env * enable test corectly * Revert "printf: fix empty interpolation string evaluates to null in printf env" This reverts commit 7f39617. * simplify codegen for interpolated strings * fix build * fix build * Merge master to feature/string-interp (dotnet#9580) * Update dependencies from https://github.com/dotnet/arcade build 20200626.2 (dotnet#9577) Microsoft.DotNet.Arcade.Sdk From Version 1.0.0-beta.20302.3 -> To Version 1.0.0-beta.20326.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Improve perf for String.filter up to 3x (dotnet#9509) * Improve perf for String.filter 2-2.5x * Cleanup: remove "foo" etc in tests * Add tests for new execution path for LOH in String.filter * Change test string * String map performance improvement (dotnet#9470) * Simplify and improve perf of String.length * Improve performance of String.map * Revert "Simplify and improve perf of String.length" * Resolves dotnet#9470 (comment) * Lingering space * Change `String` to use `new` to clarify use of ctor * Add some better tests for String.map, add side-effect test * Add tests to ensure the mapping function is called a deterministically amount of times * Fix typo * Remove "foo" from String.map tests * Perf: String.replicate from O(n) to O(log(n)), up to 12x speed improvement (dotnet#9512) * Turn String.replicate from O(n) into O(log(n)) * Cleanup String.replicate tests by removing usages of "foo" * String.replicate: add tests for missing cases, and for the new O(log(n)) cut-off points * Improve String.replicate algorithm further * Add tests for String.replicate covering all lines/branches of algo * Fix accidental comment Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Abel Braaksma <[email protected]> * Re enable tests for operators: OperatorsModule1.fs and OperatorsModule2.fs (dotnet#9516) (dotnet#9589) * Re-enabling tests from OperatorsModule1/2.fs (compile errors) * Fix compile errors in OperatorsModule1/2.fs, fix tests. Note tanh test comment. * Fix `tanh` test, ensure stable result on x86 vs x64 runtimes * Stop using exception AssertionException, so that test window shows useful info * Whitespace cleanup and redundant code removal * Cleanup spelling etc * Re-enabling int, int16, int32, int64, nativeint, incr, nullArg etc tests * Special-case floating-point assertion messages for higher precision output * Fix/update/add tests (some still failing) * Separate Checked tests, add & fix others, differentiate framework/bitness for some tests * Add branch for .NET Native (ignore cos test) * Resorting to comparing floats with a delta using Assert.AreNearEqual * Add some more tests Co-authored-by: Abel Braaksma <[email protected]> * Moved fsharpqa/Libraries/Core/Unchecked test cases to NUnit (dotnet#9576) (dotnet#9599) Co-authored-by: Thorsten Reichert <[email protected]> * Moved fsharpqa/Libraries/Core/Unchecked test cases to NUnit (dotnet#9576) (dotnet#9604) Co-authored-by: Thorsten Reichert <[email protected]> * Merge master to feature/string-interp (dotnet#9615) * Moved fsharpqa/Libraries/Core/Unchecked test cases to NUnit (dotnet#9576) * Moved fsharpqa/Libraries/Core/Reflectiontest cases to NUnit (dotnet#9611) * Migrated PreComputedTupleConstructor01.fs test case * Migrated PreComputedTupleConstructor02.fs test case * Migrated DU.fs and Record.fs test cases * Allow notebook to discover location of shared framework (dotnet#9596) Co-authored-by: Thorsten Reichert <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Phillip Carter <[email protected]> * Merge master to feature/string-interp (dotnet#9619) * Moved fsharpqa/Libraries/Core/Unchecked test cases to NUnit (dotnet#9576) * Moved fsharpqa/Libraries/Core/Reflectiontest cases to NUnit (dotnet#9611) * Migrated PreComputedTupleConstructor01.fs test case * Migrated PreComputedTupleConstructor02.fs test case * Migrated DU.fs and Record.fs test cases * Allow notebook to discover location of shared framework (dotnet#9596) Co-authored-by: Thorsten Reichert <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> * Text tweeks * don't auto-resolve types from System.Runtime.WindowsRuntime (dotnet#9644) (dotnet#9648) Co-authored-by: Brett V. Forsgren <[email protected]> * yeet (dotnet#9657) (dotnet#9661) yeet Co-authored-by: Phillip Carter <[email protected]> * yeet (dotnet#9657) (dotnet#9670) yeet Co-authored-by: Phillip Carter <[email protected]> * fix up tokenizer tests * fix code review things * fix code review things * fix code review things * fix code review things * add various testing * correct continuations for interpolated strings * fix lexer continuations and colorization for multi-line interpolated strings * revert xlf changes * fix assert * completion and brace matching (not all tests passing yet) * Fix rebuild * fix various niggles and get tests working * fix printf when '%a' in final position * fix test case * interpolated string specifer highlighting * fix triple quote interpolated string specifer highlighting * fix triple quote interpolated string specifer highlighting * fix build * fix missing error message * fix % specifiers for interpolated strings * fix % specifiers for interpolated strings * fix FCS tests * minor nits from code review * code review feedback and use struct tuples in more places * revert struct tuples * use struct tuples where possible, byrefs for index * fix byref for index * fix ksprintf block size * make recent cache entry more explicit (cleanup) * improve performance * remove unused code * Move existing Compiler.ComponentTests to a new Compiler.fs framework (dotnet#9839) (dotnet#9848) * Move existing Compiler.ComponentTests to a new Compiler.fs framework; Add 'parse' function * Changed some wording in error messages Co-authored-by: Vlad Zarytovskii <[email protected]> * Move existing Compiler.ComponentTests to a new Compiler.fs framework (dotnet#9839) * Move existing Compiler.ComponentTests to a new Compiler.fs framework; Add 'parse' function * Changed some wording in error messages * fix dotnet#9893 * fix unmantched right brace in interp string Co-authored-by: Yatao Li <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: dotnet bot <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Abel Braaksma <[email protected]> Co-authored-by: Thorsten Reichert <[email protected]> Co-authored-by: Phillip Carter <[email protected]> Co-authored-by: Brett V. Forsgren <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]>

varon · 2020-08-10T09:52:54Z

THANK YOU This is super!

MikaelUmaN · 2020-08-18T15:18:12Z

Extremely appreciated. Great work ! Thank you.

auduchinok · 2020-11-05T15:04:10Z

tests/service/TokenizerTests.fs

+let ``Tokenizer test - single-line nested string interpolation``() =
+    let tokenizedLines = 
+      tokenizeLines
+        [| " $\"abc { { contents = 1 } }\"     " |]


This doesn't seem to be a nested string interpolation. Am I misunderstanding the test name or it's an error?

@auduchinok I think it's nested because there are two, non-doubled (as in: non-escaped) nested curlies. If it was only one, it wouldn't be nested. If the space between the curlies was removed, it wouldn't be interpolated.

From the test name I was expecting nested string interpolations, like in $"""{$""}""". The test source shows a normal interpolation (though an interesting case with inner braces), and there's nothing I'd call nested. That's why I found it confusing.

Ah, I see, yes indeed. Though "nested" can, imo, mean either: an interpolated string inside an interpolated string, or the expression part nested in itself: like a nested scope in C#, or nested lists etc.

* string interploation implementation * string interploation tests * escape {{ }}, test verbatim and triple quote, implement .NET specifiers * fix tests * string interpolation tests: internal representation corner cases * string-interp tests should have --langversion:preview * string interop tests: sprintf * string interp tests: format specifier negative cases * string interp tests: format specifier negative cases, .NET-style padding * fix nested interp strings * style cleanup * lex: unify string interp stack and counter * string-interp: add test cases * fix mixed quote nested string interpolation * string-interp: add test case for multiple interpolation points with different indentation * lexfilter: push new CtxtParen at endPos for INTERP_STRING_PART and INTERP_STRING_BEGIN_PART * lexfilter: do not check undentation limit for string interpolation tokens. * FormattableString prototype * add FormattableString support * negative error checking * remove diagnostics * simpler FormattableString implementation * fix test * add testing for nested * add IFormattable support * tweak error message * tests: StringInterpolation: fix case errors * fix error message * check number of values matches * allow use of format strings with printf and friends * update baselines * fix baselines * add Experimental attributes * update string interp negative tests * stringinterp test: add PrintFormat tests * printf: fix empty interpolation string evaluates to null in printf env * enable test corectly * Revert "printf: fix empty interpolation string evaluates to null in printf env" This reverts commit 7f39617. * simplify codegen for interpolated strings * fix build * fix build * Merge master to feature/string-interp (dotnet#9580) * Update dependencies from https://github.com/dotnet/arcade build 20200626.2 (dotnet#9577) Microsoft.DotNet.Arcade.Sdk From Version 1.0.0-beta.20302.3 -> To Version 1.0.0-beta.20326.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Improve perf for String.filter up to 3x (dotnet#9509) * Improve perf for String.filter 2-2.5x * Cleanup: remove "foo" etc in tests * Add tests for new execution path for LOH in String.filter * Change test string * String map performance improvement (dotnet#9470) * Simplify and improve perf of String.length * Improve performance of String.map * Revert "Simplify and improve perf of String.length" * Resolves dotnet#9470 (comment) * Lingering space * Change `String` to use `new` to clarify use of ctor * Add some better tests for String.map, add side-effect test * Add tests to ensure the mapping function is called a deterministically amount of times * Fix typo * Remove "foo" from String.map tests * Perf: String.replicate from O(n) to O(log(n)), up to 12x speed improvement (dotnet#9512) * Turn String.replicate from O(n) into O(log(n)) * Cleanup String.replicate tests by removing usages of "foo" * String.replicate: add tests for missing cases, and for the new O(log(n)) cut-off points * Improve String.replicate algorithm further * Add tests for String.replicate covering all lines/branches of algo * Fix accidental comment Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Abel Braaksma <[email protected]> * Re enable tests for operators: OperatorsModule1.fs and OperatorsModule2.fs (dotnet#9516) (dotnet#9589) * Re-enabling tests from OperatorsModule1/2.fs (compile errors) * Fix compile errors in OperatorsModule1/2.fs, fix tests. Note tanh test comment. * Fix `tanh` test, ensure stable result on x86 vs x64 runtimes * Stop using exception AssertionException, so that test window shows useful info * Whitespace cleanup and redundant code removal * Cleanup spelling etc * Re-enabling int, int16, int32, int64, nativeint, incr, nullArg etc tests * Special-case floating-point assertion messages for higher precision output * Fix/update/add tests (some still failing) * Separate Checked tests, add & fix others, differentiate framework/bitness for some tests * Add branch for .NET Native (ignore cos test) * Resorting to comparing floats with a delta using Assert.AreNearEqual * Add some more tests Co-authored-by: Abel Braaksma <[email protected]> * Moved fsharpqa/Libraries/Core/Unchecked test cases to NUnit (dotnet#9576) (dotnet#9599) Co-authored-by: Thorsten Reichert <[email protected]> * Moved fsharpqa/Libraries/Core/Unchecked test cases to NUnit (dotnet#9576) (dotnet#9604) Co-authored-by: Thorsten Reichert <[email protected]> * Merge master to feature/string-interp (dotnet#9615) * Moved fsharpqa/Libraries/Core/Unchecked test cases to NUnit (dotnet#9576) * Moved fsharpqa/Libraries/Core/Reflectiontest cases to NUnit (dotnet#9611) * Migrated PreComputedTupleConstructor01.fs test case * Migrated PreComputedTupleConstructor02.fs test case * Migrated DU.fs and Record.fs test cases * Allow notebook to discover location of shared framework (dotnet#9596) Co-authored-by: Thorsten Reichert <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Phillip Carter <[email protected]> * Merge master to feature/string-interp (dotnet#9619) * Moved fsharpqa/Libraries/Core/Unchecked test cases to NUnit (dotnet#9576) * Moved fsharpqa/Libraries/Core/Reflectiontest cases to NUnit (dotnet#9611) * Migrated PreComputedTupleConstructor01.fs test case * Migrated PreComputedTupleConstructor02.fs test case * Migrated DU.fs and Record.fs test cases * Allow notebook to discover location of shared framework (dotnet#9596) Co-authored-by: Thorsten Reichert <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> * Text tweeks * don't auto-resolve types from System.Runtime.WindowsRuntime (dotnet#9644) (dotnet#9648) Co-authored-by: Brett V. Forsgren <[email protected]> * yeet (dotnet#9657) (dotnet#9661) yeet Co-authored-by: Phillip Carter <[email protected]> * yeet (dotnet#9657) (dotnet#9670) yeet Co-authored-by: Phillip Carter <[email protected]> * fix up tokenizer tests * fix code review things * fix code review things * fix code review things * fix code review things * add various testing * correct continuations for interpolated strings * fix lexer continuations and colorization for multi-line interpolated strings * revert xlf changes * fix assert * completion and brace matching (not all tests passing yet) * Fix rebuild * fix various niggles and get tests working * fix printf when '%a' in final position * fix test case * interpolated string specifer highlighting * fix triple quote interpolated string specifer highlighting * fix triple quote interpolated string specifer highlighting * fix build * fix missing error message * fix % specifiers for interpolated strings * fix % specifiers for interpolated strings * fix FCS tests * minor nits from code review * code review feedback and use struct tuples in more places * revert struct tuples * use struct tuples where possible, byrefs for index * fix byref for index * fix ksprintf block size * make recent cache entry more explicit (cleanup) * improve performance * remove unused code * Move existing Compiler.ComponentTests to a new Compiler.fs framework (dotnet#9839) (dotnet#9848) * Move existing Compiler.ComponentTests to a new Compiler.fs framework; Add 'parse' function * Changed some wording in error messages Co-authored-by: Vlad Zarytovskii <[email protected]> * Move existing Compiler.ComponentTests to a new Compiler.fs framework (dotnet#9839) * Move existing Compiler.ComponentTests to a new Compiler.fs framework; Add 'parse' function * Changed some wording in error messages * fix dotnet#9893 * fix unmantched right brace in interp string Co-authored-by: Yatao Li <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: dotnet bot <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Abel Braaksma <[email protected]> Co-authored-by: Thorsten Reichert <[email protected]> Co-authored-by: Phillip Carter <[email protected]> Co-authored-by: Brett V. Forsgren <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]>

dsyme mentioned this pull request Apr 8, 2020

[RFC FS-1001 POC] String Interpolation [WIP] #6770

Closed

string interploation implementation

1ba6b74

dsyme force-pushed the feature/string-interp branch from a3636c1 to 1ba6b74 Compare April 9, 2020 18:19

dsyme added 2 commits April 15, 2020 11:54

string interploation tests

23d38cc

Merge branch 'master' of https://github.com/dotnet/fsharp into featur…

2593c76

…e/string-interp

dsyme added 2 commits April 15, 2020 17:24

escape {{ }}, test verbatim and triple quote, implement .NET specifiers

cf658de

fix tests

6a9128b

cartermp added the Candidate for F# vNext label Apr 15, 2020

cartermp mentioned this pull request Apr 15, 2020

3-week rollup plan and checklist (April-May 2020) #8961

Closed

28 tasks

dsyme changed the title ~~[RFC FS-1001 POC] String Interpolation~~ [RFC FS-1001] String Interpolation Apr 15, 2020

string interpolation tests: internal representation corner cases

047fda6

Yatao Li added 2 commits April 17, 2020 01:25

string-interp tests should have --langversion:preview

b31c14f

string interop tests: sprintf

484e46c

cartermp approved these changes Aug 5, 2020

View reviewed changes

KevinRansom and others added 2 commits August 5, 2020 22:17

Merge pull request #9884 from dotnet/merges/master-to-feature/string-…

3a4066c

…interp Merge master to feature/string-interp

Merge pull request #9889 from dotnet/merges/master-to-feature/string-…

d27379f

…interp Merge master to feature/string-interp

KevinRansom approved these changes Aug 6, 2020

View reviewed changes

merge

83e63a6

abelbraaksma mentioned this pull request Aug 7, 2020

Collection of findings related to string interpolation #9893

Closed

34 tasks

dsyme added 2 commits August 7, 2020 01:52

fix #9893

60db04e

fix unmantched right brace in interp string

ba48b59

KevinRansom merged commit 656954c into master Aug 7, 2020

pkese mentioned this pull request Aug 12, 2020

Send-to-interactive of incomplete string leaves FSI waiting for more input #830

Open

auduchinok reviewed Nov 5, 2020

View reviewed changes

inouiw mentioned this pull request Jan 13, 2023

Allow nested triple-quote interpolation strings #14535

Closed


		let stringKindValue = int32 ((bits &&& stringKindMask) >>> stringKindStart)
		let stringKind : LexerStringKind =

[RFC FS-1001] String Interpolation #8907

[RFC FS-1001] String Interpolation #8907

Conversation

dsyme commented Apr 8, 2020 • edited Loading

dsyme commented Apr 8, 2020

abelbraaksma commented Apr 9, 2020

Happypig375 commented Apr 9, 2020

dsyme commented Apr 9, 2020

dsyme commented Apr 9, 2020 • edited Loading

Swoorup commented Apr 15, 2020

cartermp commented Apr 15, 2020

swaroop-sridhar commented Apr 15, 2020

smoothdeveloper commented Apr 15, 2020

yatli commented Apr 15, 2020

dsyme commented Apr 15, 2020

yatli commented Apr 15, 2020

dsyme commented Apr 15, 2020

dbrattli commented Apr 16, 2020 • edited Loading

yatli commented Apr 16, 2020

abelbraaksma commented Apr 16, 2020 • edited Loading

dsyme commented Apr 16, 2020

dsyme commented Aug 5, 2020

cartermp commented Aug 5, 2020

dsyme commented Aug 5, 2020

cartermp left a comment

Choose a reason for hiding this comment

KevinRansom left a comment

Choose a reason for hiding this comment

KevinRansom Aug 6, 2020

Choose a reason for hiding this comment

KevinRansom Aug 6, 2020

Choose a reason for hiding this comment

KevinRansom Aug 6, 2020

Choose a reason for hiding this comment

abelbraaksma commented Aug 6, 2020 • edited Loading

abelbraaksma commented Aug 7, 2020 • edited Loading

dsyme commented Aug 7, 2020

dsyme commented Aug 7, 2020

KevinRansom commented Aug 7, 2020

realvictorprm commented Aug 7, 2020

dsyme commented Aug 7, 2020

abelbraaksma commented Aug 7, 2020 • edited Loading

adelarsq commented Aug 7, 2020

varon commented Aug 10, 2020

MikaelUmaN commented Aug 18, 2020

auduchinok Nov 5, 2020

Choose a reason for hiding this comment

abelbraaksma Nov 22, 2020 • edited Loading

Choose a reason for hiding this comment

auduchinok Nov 22, 2020 • edited Loading

Choose a reason for hiding this comment

abelbraaksma Nov 22, 2020

Choose a reason for hiding this comment

dsyme commented Apr 8, 2020 •

edited

Loading

dsyme commented Apr 9, 2020 •

edited

Loading

dbrattli commented Apr 16, 2020 •

edited

Loading

abelbraaksma commented Apr 16, 2020 •

edited

Loading

abelbraaksma commented Aug 6, 2020 •

edited

Loading

abelbraaksma commented Aug 7, 2020 •

edited

Loading

abelbraaksma commented Aug 7, 2020 •

edited

Loading

abelbraaksma Nov 22, 2020 •

edited

Loading

auduchinok Nov 22, 2020 •

edited

Loading