Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List.transpose should throw error when given jagged array (#6908) #6989

Merged
merged 2 commits into from
Jun 27, 2019
Merged

List.transpose should throw error when given jagged array (#6908) #6989

merged 2 commits into from
Jun 27, 2019

Conversation

PatrickMcDonald
Copy link
Contributor

  • transpose does not throw when one of the elements is empty

Fixes #6908

@PatrickMcDonald
List.transpose should throw error when given jagged array (dotnet#6908)
10bf1fc 
* transpose does not throw when one of the elements is empty
cartermp
cartermp approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickMcDonald!

TIHan
TIHan approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@TIHan TIHan merged commit 6af64a7 into dotnet:master Jun 27, 2019
@TIHan
Copy link
Contributor

TIHan commented Jun 27, 2019

Thanks for your work and patience.

@PatrickMcDonald
Copy link
Contributor Author

👍 Always a pleasure!

@PatrickMcDonald PatrickMcDonald deleted the transpose-fix branch June 28, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

@TIHan TIHan TIHan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List.transpose discards data instead of throwing an exception
4 participants
@PatrickMcDonald @TIHan @KevinRansom @cartermp