Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LangVersion on 'Add missing case for underscore in for _ =' #6931

Merged

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Jun 2, 2019

#6867

This makes this recently merged file respond to the langversion flag.

This PR builds on the unmergedPR: "Ensure that Language Version support flows to Parser"
#6891

The commit to review is the most recent. 51538fd

  1. The PR: tests for language version support for the feature.
  2. Re-enables the "core/forexpression" tests for some reason they weren't running.
  3. Hides the forexpression tests if the build is a version earlier than 4.7
  4. Adds versioning tests that ensure:
    a. When langVersion is 4.6, we get the error
    b. When langVersion is 4.7 or above it succeeds

@KevinRansom KevinRansom force-pushed the langvalMissingCase branch 3 times, most recently from 22a6656 to 218ca54 Compare June 3, 2019 20:29
@KevinRansom KevinRansom force-pushed the langvalMissingCase branch from 218ca54 to d680c0c Compare June 3, 2019 20:33
@KevinRansom KevinRansom merged commit 4a8685e into dotnet:release/fsharp47 Jun 3, 2019
@KevinRansom KevinRansom deleted the langvalMissingCase branch July 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants