Add match! to structure #5473
Add match! to structure #5473
Conversation
| @@ -259,7 +260,7 @@ module Structure = | |||
| | SynExpr.LetOrUse (_,_,bindings, body, _) -> | |||
| parseBindings bindings | |||
| parseExpr body | |||
| | SynExpr.Match (seqPointAtBinding,_expr,clauses,_,r) -> | |||
| | SynExpr.Match (seqPointAtBinding,_expr,clauses,_,r) | SynExpr.MatchBang (seqPointAtBinding, _expr, clauses, _, r) -> | |||
There was a problem hiding this comment.
I’m sure there no such formatting in the whole repository.
There was a problem hiding this comment.
There was a problem hiding this comment.
@cartermp,
From a readability perspective, I think we should prefer the fall through match, I agree with @vasily-kirichenko.
It is a certainty that we can, using this repo, point to an example of every type of formatting style that could possibly exist. For sure fall through matches with the separate cases per line is the most common, and I think readable format.
Kevin
There was a problem hiding this comment.
I can change it. I'll also change the other case in the compiler that does this.
tests/service/StructureTests.fs
Outdated
| | Some _ -> () // 7 | ||
| | None -> // 8 | ||
| let x = () // 9 | ||
| () // 10 |
There was a problem hiding this comment.
The example code is not realistical.
There was a problem hiding this comment.
This is just like the other tests. Do you have a suggested improvement?
There was a problem hiding this comment.
maybe {
match! Some None with
| Some _ ->
()
| None ->
match None with
| Some _ -> ()
| None ->
let x = ()
()
} 
cartermp
changed the title
| @@ -259,7 +260,7 @@ module Structure = | |||
| | SynExpr.LetOrUse (_,_,bindings, body, _) -> | |||
| parseBindings bindings | |||
| parseExpr body | |||
| | SynExpr.Match (seqPointAtBinding,_expr,clauses,_,r) -> | |||
| | SynExpr.Match (seqPointAtBinding,_expr,clauses,_,r) | SynExpr.MatchBang (seqPointAtBinding, _expr, clauses, _, r) -> | |||
There was a problem hiding this comment.
@cartermp,
From a readability perspective, I think we should prefer the fall through match, I agree with @vasily-kirichenko.
It is a certainty that we can, using this repo, point to an example of every type of formatting style that could possibly exist. For sure fall through matches with the separate cases per line is the most common, and I think readable format.
Kevin
|
Thanks mate. |
|
Also rebased atop master. |
Fixes #5456