fix StartUpToDateCheck with VSUTDCF_DTEEONLY option, #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricosada
force-pushed
the
issue_471_uptodate_crash
branch
from
67b5654 to
03e4720
Compare
with VSUTDCF_DTEEONLY: - QueryStartUpToDateCheck return option not supported - StartUpToDateCheck return operation not implemented
enricosada
force-pushed
the
issue_471_uptodate_crash
branch
from
03e4720 to
47e2400
Compare
|
@enricosada thanks for taking a look at this. We don't want to leave it unsupported, though, up-to-date check should still work even with the DTEEONLY flag. If we see this flag, I believe we should simply take a slightly different codepath (avoid some APIs that do not apply in this scenario). Let me check C# project system and see what proper behavior should be. |
|
A proper fix is better. |
|
Closing this out in favor of #479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #471
return build not up-to-date if flag VSUTDCF_DTEEONLY is used for StartUpToDateCheck.