AllMethInfosOfTypeInScope with shortcut of extension methods #4457
Conversation
forki
force-pushed
the
intrinsic
branch
12 times, most recently
from
6a92131 to
38cbe97
Compare
forki
changed the title
|
@forki The code looks fine - but what's the reason for the change? e.g. write the description for the PR :) thanks! |
|
Fone |
|
@forki noch fone? :) |
|
Fatfingered lol |
cartermp
requested review from
KevinRansom and
dsyme
and removed request for
KevinRansom
|
@forki looks like there are conflicts. Is this PR still good? Looks like it is on the surface at least |
|
Will try to rebase later today.
Am Fr., 8. Feb. 2019, 18:29 hat Phillip Carter <[email protected]>
geschrieben:
… @forki <https://github.com/forki> looks like there are conflicts. Is this
PR still good? Looks like it is on the surface at least
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4457 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNOoAwK54DA4JiaTOkDSA97uTJk5Nks5vLbPmgaJpZM4SgCWb>
.
|
|
rebased. let's see if it becomes green |
|
@KevinRansom it looks like the build succeeded but some error during fcs publishing happened. ist this related? |
|
The FCS CI has some flakiness to it. As you've found, just close/re-open ought to solve it. |
|
@dsyme you said the code looks fine, does that count as a sign-off? |
|
would be good to double check the AtMostOnce calls. but I think I was very conservative about this here |
|
Ugh I have half a mind to just delete that flaky test |
|
Why is NameResolution.fsi showing as 100% change in this PR? |
|
I think my VS changed encoding. But I checked and now it's same as other
files around it
Am Di., 19. Feb. 2019, 01:45 hat Don Syme <[email protected]>
geschrieben:
… Why is NameResolution.fsi showing as 100% change in this PR?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4457 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNFVR6sV0rOXbhEZ72c1ULgodoappks5vO0k7gaJpZM4SgCWb>
.
|
|
rebased again. |
forki
force-pushed
the
intrinsic
branch
2 times, most recently
from
33d3888 to
984d5da
Compare
|
and rebased yet another time. |
|
and another time.. |
|
thank you for this. |
When we check for method or property Infos we often don't need all Infos but only the first one. This pr avoids looking though all inheritance layers all the time.