Remove duplicated navigation bar items for properties with getters and setters #2146
Conversation
| | [SynMemberDefn.Member(memberDefn=Binding(headPat=SynPat.LongIdent(lid1, Some(info1),_,_,_,_)) as binding1) | ||
| SynMemberDefn.Member(memberDefn=Binding(headPat=SynPat.LongIdent(lid2, Some(info2),_,_,_,_)) as binding2)] -> | ||
| // ensure same long id | ||
| assert((lid1.Lid,lid2.Lid) ||> List.forall2 (fun x y -> x.idText = y.idText)) |
There was a problem hiding this comment.
What is the assert doing here? Are we just throwing if this is not fulfilled?
There was a problem hiding this comment.
I've ported this code from here https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/vs/ServiceParseTreeWalk.fs#L418-L454 I think that if this assertion violated, it means that something very wrong happened with the parser and we must see it in debug configuration.
| @@ -26,10 +26,10 @@ type FSharpNavigationDeclarationItemKind = | |||
|
|
|||
| /// Represents an item to be displayed in the navigation bar | |||
| [<Sealed>] | |||
| type FSharpNavigationDeclarationItem(uniqueName: string, name: string, kind: FSharpNavigationDeclarationItemKind, glyph: GlyphMajor, range: range, bodyRange: range, singleTopLevel:bool) = | |||
| type FSharpNavigationDeclarationItem(uniqueName: string, name: string, kind: FSharpNavigationDeclarationItemKind, glyph: GlyphMajor, range: range, | |||
There was a problem hiding this comment.
@vasily-kirichenko ---
I suppose we should start formatting lines so that they can be seen in a GitHub PR.
I know I am the worst offender for long lines, but, perhaps we should limit line lengths to 120 characters max. Although this is a terrible waste on my new monitor which is currently showing a 463 characters wide editor display :-(
There was a problem hiding this comment.
I'm for 120 or maybe 140 characters lines 👍
Maybe we should add this code style rule to devguide.md
There was a problem hiding this comment.
I definitely support that change.
…d setters (dotnet#2146) * remove duplicated navigation bar items for properties with getters and setters * fix glyphs for class let bindings * better navigation bar glyphs * fix accessibility for members and let bindings
This fixes #1 and #2 from #2132 and adds accessibility aware glyphs: