Fix Internal error when analysing incomplete inherit member

[edgarfgp]

Description

Fixes #17902

Checklist

• Test cases added
• Release notes entry updated

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

[auduchinok]

I think this may be a not good fix here, because it affects to many different places where this type is used. The exception immediately shows that something is really wrong, and a wrong range may go unnoticed for a long time.

It's probably much better to fix it more systematically (e.g. use SynLongIdent option instead of SynLongIdent in places of known recovery) and/or check it in the outer code.

[edgarfgp]

Range.Zero is commonly used in similar scenarios in the SyntaxTree file. But I agree we could use option here

[auduchinok]

Range.Zero is commonly used in similar scenarios in the SyntaxTree file.

Well, that's wrong because it means some node with a range like (10,20)-(10,30) can now contain a node with range (0, 0)-(0, 0) which is outside of its parent node range. Anyway, we need to fix this more systematically in future.

[brianrourkeboll]

Style nit: I generally think keeping pattern matching flat where possible (instead of adding nested match expressions) makes the top-level match easier to understand, but feel free to ignore if you disagree.

[edgarfgp]

@psfinaki Sorry to bother you again. Could you help me update the last salsa test https://dev.azure.com/dnceng-public/public/_build/results?buildId=850191&view=ms.vss-test-web.build-test-results-tab&runId=22075436&resultId=108303&paneView=debug. Trying to do it using the CI is really painful :(