Requires tactics Approval: Restore the ability to identify CompileBefore and CompileAfter values

[KevinRansom]

We fixed an issue that impacted SourceLink generation for F# developers, this broke an existing rider feature, that depended on the ability to identify CompileBefore and CompileAfter values. We value our users being able to use the LTS release with their current preferred dev tooling.

This PR cherry picks the two fix PRs from main into LTS.

We failed to discover this issue locally because we no longer use the feature rider depended on. @auduchinok has modified Rider to use the updated implementation but that is only in F# 9.0 and Rider needs to support LTS and that branch does not contain these fixes. that includes these cherrypicks and has verified the fixes work with Rider.

[github-actions]

✅ No release notes required

[KevinRansom]

@auduchinok

Hey,
can you submit a PR that verifies any further dependencies you have taken on values and collections in our repo. Not general sdk things, just stuff you know comes from the F# props and targets. Things like: OtherFlags, the FSharp version settings, TailCall, etc, but only if you depend on them.

It would be nice to not break you in the future, although I am certain we will.

Thanks

Kevin

[vzarytovskii]

We don't need package version bump, right?

[KevinRansom]

Sigh !!!! yes we do.

It's been approved by tactics.

[auduchinok]

Thank you very much @KevinRansom!

@auduchinok

Hey,
can you submit a PR that verifies any further dependencies you have taken on values and collections in our repo. Not general sdk things, just stuff you know comes from the F# props and targets. Things like: OtherFlags, the FSharp version settings, TailCall, etc, but only if you depend on them.

Could you please elaborate on what exactly should the PR contain? We do indeed process things like OtherFlags and other F#-specific properties. Mostly we use this data to build the correct project information for FCS. The order-related ones are also used in the UI and in the logic around reordering files.

[auduchinok]

@KevinRansom Do you know if this is already in .NET 9? It seems it's not included in RC2.

[KevinRansom]

No ... and I don't really know why. Except, release/dev17.12 which is our 9.0.1xx branch hasn't been updated. I will work with vlad to figure out what to do.

[KevinRansom]

@auduchinok Since, it's already approved and 9.0.1xx is still open for emergencies chet just said we can merge and flow without additional approvals. So we will see if we can get this in.

Thanks for checking in, I appreciate it.