Clean up FsUnit #17781
Merged
Clean up FsUnit #17781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
psfinaki
commented
Sep 24, 2024
psfinaki
commented
Sep 24, 2024
psfinaki
commented
Sep 24, 2024
KevinRansom
approved these changes
Sep 25, 2024
T-Gro
approved these changes
Sep 26, 2024
esbenbjerre
pushed a commit
to esbenbjerre/fsharp
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the constructions and helpers that are not necessary anymore.
I first thought to remove FsUnit entirely, but that would mean rewriting a lot of tests from the piping style - that's not worth it and not beneficial.
See comments.