Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass SynPat.Typed nodes to original continuation. #17510

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Aug 8, 2024

Description

Fixes #17508

@BoundedChenn31 thanks for reporting this issue. I believe this PR fixes the problem.
@vzarytovskii which file would need a release note?

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf nojaf requested a review from a team as a code owner August 8, 2024 08:23
Copy link
Contributor

github-actions bot commented Aug 8, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@vzarytovskii
Copy link
Member

Thanks for the quick fix, it should be 9.0.100 now

@psfinaki
Copy link
Member

psfinaki commented Aug 8, 2024

Thanks Florian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Compiler fails to recognise namespace in FQN with enabled GraphBasedChecking
4 participants