Fixes #17447 -MethodAccessException on equality comparison of a record with private fields #17467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
T-Gro
approved these changes
Jul 31, 2024
psfinaki
approved these changes
Jul 31, 2024
This was referenced Aug 13, 2024
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Sep 24, 2024
… record with private fields (dotnet#17467) * Fix17447 * tests + readme
vzarytovskii
added a commit
that referenced
this pull request
Oct 7, 2024
* Update azure-pipelines.yml * Refactor CE checking (#17464) (#17493) Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: vzarytovskii <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update azure-pipelines.yml * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 2524346 (#17610) * Fixes #17447 -MethodAccessException on equality comparison of a record with private fields (#17467) * Fix17447 * tests + readme * fixes #17541 - Equals visibility for DU's (#17548) * update version number * Switch to new VMR control set (#17703) (port from main) (#17788) * Now that fsharp is on 9.0, we can switch to the new control set. Generally: - DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build. - DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build. - ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build. - ExcludeFromSourceBuild -> ExcludeFromSourceOnlyBuild * Split out source build args * Split out source build args * Remove unnecessary source build env var set * Add properties to the bootstrap compiler build * BuildRepo -> BuildInnerRepo * Only build proto repo in inner build * Additional VMR properties for completeness * Rename sourcebuild.props -> dotnetbuild.props --------- Co-authored-by: Petr <[email protected]> * respect generic arity in method uniqueness * [17.12] Turn off realsig when building product and proto (#17808) * Bugfix : make sure nullness does not break XmlDoc info import for methods and types (#17741) * Remove nullness signal in string-based type encoding of a symbol (since it is used for xmldoc lookup) * release notes * Discard unused values * Rendering AllowsRefStruct for type parameters (#17706) * Update azure-pipelines.yml --------- Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: Petr <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: vzarytovskii <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom <[email protected]> Co-authored-by: Matt Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17447
The generation of Augmented Equals methods, were created with an incorrect visibility. It should have restricted the visibility to match the type that contained the method. Instead it set the visibility to match the scope of the field.
I.e private.
This meant that the compiler generated it:
However, because the type is: 'class Module1/Value' it should be marked public