-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize simple mappings with binds and/or sequentials before single yield #17419
Merged
vzarytovskii
merged 8 commits into
dotnet:main
from
brianrourkeboll:collection-lowering-implicit-yields
Jul 27, 2024
Merged
Optimize simple mappings with binds and/or sequentials before single yield #17419
vzarytovskii
merged 8 commits into
dotnet:main
from
brianrourkeboll:collection-lowering-implicit-yields
Jul 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously, the newer collection lowering optimizations were not being applied when the body of the mapping involved one or more let-bindings and an implicit yield. Now, they are. ```fsharp [ for x in xs do let y = z x + y ] ```
❗ Release notes required
|
brianrourkeboll
changed the title
Optimize simple mappings with
Optimize simple mappings with Jul 17, 2024
let
-bindings & implicit yieldlet
-bindings before yield
brianrourkeboll
changed the title
Optimize simple mappings with
Optimize simple mappings with binds and/or sequentials before single yield
Jul 18, 2024
let
-bindings before yield…on-lowering-implicit-yields
psfinaki
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, thanks for further tuning the optimization!
vzarytovskii
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #16832, #16948, #17067.
let
-bindings and/orunit
-typed sequential expressions before a single explicit or implicit yield. (Noticed in FS-1135 implementation - random functions for collections #17277 (comment).)Before, with #16832, #16948, #17067, etc., when
xs
was a list (or an array, or an integral range, depending), an expression like this would get optimized to a fastwhile
-loopas would
but this would not
nor would
Now, the latter two are optimized as well.
Checklist
Notes