Enable PGO - alternative approach

[psfinaki]

Description

This should eventually make the FSC and FSI start about 30% faster. The implementation is inspired by the runtime targets.

Fixes #12636
Fixes #13328

[github-actions]

✅ No release notes required

[psfinaki]

Hi @EgorBo, so this is an alternative approach to enable PGO, without doing profile generation ourselves.
However - this doesn't seem to work so far, as in, benchmarks don't show any improvements.

Any ideas what could be wrong?

[vzarytovskii]

@EgorBo any pointers on how to figure out why is profile we get from nuget is not applying, and if we generate it locally, it shows a difference?

[EgorBo]

@psfinaki @vzarytovskii I presume you test it on fsi? have you added fsi as a training scenario to dotnet-optimization repo? Otherwise it produces some MIBC trained to TechEmpower, console apps and for F# it's only "build Giraffe" scenario

[vzarytovskii]

@psfinaki @vzarytovskii I presume you test it on fsi? have you added fsi as a training scenario to dotnet-optimization repo? Otherwise it produces some MIBC trained to TechEmpower, console apps and for F# it's only "build Giraffe" scenario

We have tested on fsc, since that's the only F# scenario in the optimization repo as of now.

@psfinaki did you try to build Giraffe with and without profile applied in this PR? Does it change anything?

[psfinaki]

So far I have only tried running published fsc against an empty test.fsx script. That was enough to show the differece in that other PR with us creating the profile.

Let me try Giraffe.

[psfinaki]

@vzarytovskii @EgorBo I'm afraid I don't see any difference in Giraffe compilation either :( it's the same execution time basically.

[EgorBo]

@vzarytovskii @EgorBo I'm afraid I don't see any difference in Giraffe compilation either :( it's the same execution time basically.

Do you a MIBC that works locally? can you send it to me? I'll check weigths in it

[vzarytovskii]

@EgorBo did you, by any chance, look at it? Curious what's the difference between those.

[EgorBo]

@EgorBo did you, by any chance, looked at it? Curious what's the difference between those.

The only @psfinaki collected looks extremely weird to me. I propose we merge this PR as is since it generally looks corret to me, the problem must be inside the dotnet-optimization repo, once we figure it out and fix it should propagate a correct MIBC and optimize things out, hopefully 🙂 I'll take a look on Friday

[KevinRansom]

When I get less sick we should talk about this.

[KevinRansom]

We need to ship fsc and fsi to the dotnetsdk as il assemblies not native compiled assemblies.

The sdk native compiles F# in this project here: https://github.com/dotnet/sdk/blob/main/src/Layout/tool_fsharp/tool_fsc.csproj

[KevinRansom]

So imagine, we will need to work with the sdk team to enable the pgo stuff ... at least if it relies on native compilation.

[KevinRansom]

We called certainly add the mibc files to the package we insert into the sdk.

[vzarytovskii]

I don't think sdk does anything, @baronfel doesn't it just repack stuff from nugets?

[psfinaki]

I was looking at the tool_fsc (and also this) and that was my impression.

[psfinaki]

Will split this into 2 parts, closing this for now.