Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fsi error message to mention --compilertool: #16264

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

smoothdeveloper
Copy link
Contributor

mention --compilertool:<extensionspath> in the message when an extension is not registered for direct action for the user.

First, let see which tests break by changing the message.

mention `--compilertool:<extensionspath>` in the message when an extension is not registered.
@smoothdeveloper smoothdeveloper requested a review from a team as a code owner November 12, 2023 21:35
@vzarytovskii vzarytovskii marked this pull request as draft November 13, 2023 13:29
@smoothdeveloper
Copy link
Contributor Author

/run xlf

  Co-authored-by: smoothdeveloper <[email protected]>
Copy link
Contributor

@smoothdeveloper
Copy link
Contributor Author

Well, this is green, it improves the user experience. #16261 also improves the situation by giving the right pointers to the official FSI documentation pages.

@smoothdeveloper smoothdeveloper marked this pull request as ready for review November 13, 2023 23:19
@psfinaki psfinaki changed the title [WIP] Update fsi error message to mention --compilertool: Update fsi error message to mention --compilertool: Nov 21, 2023
@psfinaki psfinaki enabled auto-merge (squash) November 21, 2023 17:14
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@psfinaki psfinaki merged commit 31f5610 into dotnet:main Nov 21, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants