Fix parameter name hints crashing with multi-line arguments #15004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
approved these changes
Mar 30, 2023
vzarytovskii
approved these changes
Mar 30, 2023
vzarytovskii
pushed a commit
that referenced
this pull request
Apr 1, 2023
* Fix parameter name hints crashing with multi-line arguments (#15004) * Return type hints (#14998) --------- Co-authored-by: Petr Pokorny <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]>
kant2002
pushed a commit
to kant2002/fsharp
that referenced
this pull request
Apr 1, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14885 which caused hints to stop working in certain files when parameter name hints were enabled.
The cause was that we're trying to look at arguments passed to a function and see if they're variables with the same name as the named parameter name. And we looked at a line substring between
range.StartColumnandrange.EndColumn. However the argument doesn't have to be a variable and can span multiple lines (like a lambda or a list) and then we're trying to get an impossible substring, e.g. of negative length.