Do not skip locals init in state machines #14984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psfinaki
approved these changes
Mar 27, 2023
|
Thanks @kerams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13386.
The problem turned out not to be the
initobjforTaskAwaiter, but the fact that the code emitted by task builder relies on locals being initialized. Randomly initialized bool flags could result in semi-arbitrary code being executed, like an exception handler despite no exception being thrown.An alternative solution would have been to manually initialize every local used by the state machine in
MoveNext, enabling user code, which is inlined, to potentially benefit from no initialization.