Fixing completion suggestions for collections of anonymous records #14976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-members-on-a-anonymous-record-in-a-collection
…ng-members-on-a-anonymous-record-in-a-collection
0101
approved these changes
Mar 27, 2023
abonie
approved these changes
Mar 27, 2023
|
A bit late to the party - but shouldn't anonymous records actually be considered as a type even from the compiler perspective? |
vzarytovskii
pushed a commit
that referenced
this pull request
Mar 28, 2023
Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: Jakub Majocha <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Fixing completion for collections of anonymous records (#14976)
kant2002
pushed a commit
to kant2002/fsharp
that referenced
this pull request
Apr 1, 2023
T-Gro
deleted the
14812-keyword-suggestions-shown-when-accessing-members-on-a-anonymous-record-in-a-collection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #14812 affected access to a collection of anonymous records, processed either via indexer or via a module function converting the collection to a single item.
The existing autocomplete logic in VS adds in keywords if the suggestion isn't for a long dotted-identifier, or if it isn't for a known type. In this case, anonymous records were not considered to be a type (isForType was false), but from a suggestion perspective, they are a type and should be treated here for the completion list just like regular records
Before:
After:
