Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling --times:files.csv test which breaks CI #14594

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Disabling --times:files.csv test which breaks CI #14594

merged 1 commit into from
Jan 12, 2023

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Jan 11, 2023

No description provided.

@T-Gro T-Gro marked this pull request as ready for review January 11, 2023 20:31
@T-Gro T-Gro requested a review from a team as a code owner January 11, 2023 20:31
psfinaki
psfinaki approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create some ticket about that so that we don't forget

@T-Gro T-Gro merged commit dad30df into dotnet:main Jan 12, 2023
@T-Gro
Copy link
Member Author

T-Gro commented Jan 12, 2023

/backport to release/dev17.5

@github-actions
Copy link
Contributor

Started backporting to release/dev17.5: https://github.com/dotnet/fsharp/actions/runs/3901522878

@github-actions
Copy link
Contributor

@T-Gro an error occurred while backporting to release/dev17.5, please check the run log for details!

Error: @T-Gro is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=T-Gro

@T-Gro
Copy link
Member Author

T-Gro commented Jan 12, 2023

/backport to release/dev17.5

@github-actions
Copy link
Contributor

Started backporting to release/dev17.5: https://github.com/dotnet/fsharp/actions/runs/3902977654

@github-actions github-actions bot mentioned this pull request Jan 12, 2023
Merged
@allisonchou allisonchou mentioned this pull request Jan 16, 2023
Closed
@T-Gro T-Gro deleted the disable-flaky-times-csv-test branch February 2, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
release/17.6
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T-Gro @vzarytovskii @psfinaki