Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fslex and fsyacc to 11.0.1 #14584

Merged
merged 10 commits into from
Jan 13, 2023
Merged

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 11, 2023

Fixes #14583
I copied to source from the 11.0.1

@nojaf nojaf requested a review from a team as a code owner January 11, 2023 10:22
@vzarytovskii
Copy link
Member

That's a lot of changes @nojaf do you happen to know if I can easily find commits list in the fslexyacc repo, which were included in the release?

@vzarytovskii
Copy link
Member

@dsyme was fslexyacc changed in any way when having a local copy of compiler? Because in this case, just updating it from upstream might not work properly.

@nojaf
Copy link
Contributor Author

nojaf commented Jan 11, 2023

Do you have any idea what release you were on, to begin with?
There are some release notes here.

All the CI passed (expect for something which I believe to be unrelated, https://github.com/dotnet/fsharp/runs/10576589137)

@dotnet dotnet deleted a comment from github-actions bot Jan 11, 2023
@vzarytovskii
Copy link
Member

Yep, apparently one of the last updates was in #6355 to 8.0.1

@nojaf
Copy link
Contributor Author

nojaf commented Jan 11, 2023

That would explain why there are so many changes I guess.

@dsyme
Copy link
Contributor

dsyme commented Jan 11, 2023

I looked through and didn't see any changes in fslex or fsyacc that affect how the grammar is being processed. By the look of it I would expect exactly the same tables and generated source to be generated

@nojaf
Copy link
Contributor Author

nojaf commented Jan 12, 2023

@dsyme @vzarytovskii is there anything left to address here?

@dsyme
Copy link
Contributor

dsyme commented Jan 13, 2023

For me this is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update FsLexYacc
4 participants