-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fslex and fsyacc to 11.0.1 #14584
Conversation
That's a lot of changes @nojaf do you happen to know if I can easily find commits list in the fslexyacc repo, which were included in the release? |
@dsyme was fslexyacc changed in any way when having a local copy of compiler? Because in this case, just updating it from upstream might not work properly. |
Do you have any idea what release you were on, to begin with? All the CI passed (expect for something which I believe to be unrelated, https://github.com/dotnet/fsharp/runs/10576589137) |
Yep, apparently one of the last updates was in #6355 to 8.0.1 |
That would explain why there are so many changes I guess. |
I looked through and didn't see any changes in fslex or fsyacc that affect how the grammar is being processed. By the look of it I would expect exactly the same tables and generated source to be generated |
@dsyme @vzarytovskii is there anything left to address here? |
For me this is ok |
Fixes #14583
I copied to source from the 11.0.1