Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix net452 template #14561

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

@vzarytovskii vzarytovskii requested a review from a team as a code owner January 9, 2023 11:17
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove all framework types lower than net48, and add I believe add one for net 4.8.1.
We do no testing for anything lower than 4.8 anyway, and these are for creating new projects. If a developer believes their project runs on a lower dotnet framework they can manually edit the project.

Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh they are controlled by vs.

@KevinRansom KevinRansom enabled auto-merge (squash) January 13, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants