Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler error when using instance let-bindings on static class #14560

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Compiler error when using instance let-bindings on static class #14560

merged 2 commits into from
Jan 10, 2023

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Jan 9, 2023

Fixes one the multiple missing error reporting in #13147

@edgarfgp edgarfgp requested a review from a team as a code owner January 9, 2023 09:33
psfinaki
psfinaki approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuously improving our diagnostics, that's valuable :)

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Jan 9, 2023

Thanks for continuously improving our diagnostics, that's valuable :)

Boy Scout mindset : leave the language better that I found it 🙂

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Jan 9, 2023

I have 2 more PR to raise regarding the static classes. Will wait for this one to be merged so it is easy to review :)

@0101 0101 merged commit a20cda7 into dotnet:main Jan 10, 2023
@allisonchou allisonchou mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@0101 0101 0101 approved these changes

Assignees
No one assigned
Labels
release/17.6
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgarfgp @0101 @psfinaki @vzarytovskii