-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing CI runs #14553
Reducing CI runs #14553
Conversation
I'd leave trimming tests intact for now. We're mostly testing that trimmer/linker can process both and not regressed. |
It's still running, just only with the compressed version. |
No, what I meant is that we should leave both of them running. We want to make sure uncompressed metadata is trimmed correctly too, since it's to stay in some libraries for a long time. For example, FSharp.Core shipped uncompressed, and will be uncompressed for some time. |
Compilers supporting compression have been available since early november. dotnet sdk 7.0.0. VS 17.4.0. |
Ok, trimming test stays in doubled mode then, change already done. |
FIY, this is timing of the different test suites used in the longest CI job:
Proof for starting FsharpSuite.Tests on the background:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=129075&view=logs&j=09cc464c-89cd-5758-006d-ba9e3958cfa9&t=098678ff-b2f3-5c88-44d3-4c7be2f47e75&l=2813
(FsharpSuite.Tests is started as a spinoff, then all the smaller/faster test suites happen sequentially, then it waits for FsharpSuite.Tests to finish)