Ditch DictImp GetEnumerator<T> code that was needed because of a runtime bug #14509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0101
approved these changes
Dec 27, 2022
|
So, what happens if |
The worst case is that repeated access to .Current after enumeration has finished (MoveNext() returned false) will not throw. I tried searching trough the runtime repo, but I do not see links which would tell me which versions this went into. |
|
But since it was 4 years ago, it means that versions 6 and 7 have it (the only supported versions as of now?). |
0101
approved these changes
Jan 2, 2023
vzarytovskii
approved these changes
Jan 2, 2023
psfinaki
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has been fixed in the meantime.
Original issue:
F#: #5910
Runtime: dotnet/runtime#11488
Resolution in runtime repo:
dotnet/coreclr#21368
Tests:
