remove multi-emit - internal restriction #14478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
changed the title
T-Gro
reviewed
Dec 16, 2022
T-Gro
reviewed
Dec 16, 2022
T-Gro
reviewed
Dec 16, 2022
T-Gro
reviewed
Dec 16, 2022
KevinRansom
force-pushed
the
investigate
branch
from
c1d6dc6 to
25f3252
Compare
KevinRansom
force-pushed
the
investigate
branch
2 times, most recently
from
81da03f to
cdb51b8
Compare
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
KevinRansom
force-pushed
the
investigate
branch
from
a0568ac to
093e444
Compare
T-Gro
approved these changes
Dec 22, 2022
vzarytovskii
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi-emit pr: #12722
Introduced a limitation of 30 submissions visibility for any newly introduced internal value.
The reason for the limitation was that submission assemblies include 30 internals visible for assemblies with the name FSI_ASSEMBLY_nnnn ...
This PR removes the limitation by removing the naming pattern for assemblies and using assembly versioning for each assembly submission.
In order to make this work, assemblyresolvecore in fsi.fs was updated to do assembly fullname resolution when resolving dynamic assemblies.
It also removes the warning and adds a test.
I also did some more minor rework around signing to allow keypairs and keyfiles to be specified as raw byte arrays to be specified with bytearrays rather than merely from files.