IlxGen parallelization

src/Compiler/AbstractIL/il.fs

@@ -3902,7 +3902,7 @@ let prependInstrsToCode (instrs: ILInstr list) (c2: ILCode) =
     // If there is a sequence point as the first instruction then keep it at the front
     | I_seqpoint _ as i0 ->
         let labels =
-            let dict = Dictionary.newWithSize c2.Labels.Count
+            let dict = Dictionary.newWithSize (c2.Labels.Count * 2) // Decrease chance of collisions by oversizing the hashtable
 
             for kvp in c2.Labels do
                 dict.Add(kvp.Key, (if kvp.Value = 0 then 0 else kvp.Value + n))
@@ -3915,7 +3915,7 @@ let prependInstrsToCode (instrs: ILInstr list) (c2: ILCode) =
         }
     | _ ->
         let labels =
-            let dict = Dictionary.newWithSize c2.Labels.Count
+            let dict = Dictionary.newWithSize (c2.Labels.Count * 2) // Decrease chance of collisions by oversizing the hashtable
 
             for kvp in c2.Labels do
                 dict.Add(kvp.Key, kvp.Value + n)

src/Compiler/AbstractIL/ilmorph.fs

@@ -37,7 +37,7 @@ let code_instr2instrs f (code: ILCode) =
     adjust[old] <- nw
 
     let labels =
-        let dict = Dictionary.newWithSize code.Labels.Count
+        let dict = Dictionary.newWithSize (code.Labels.Count * 2) // Decrease chance of collisions by oversizing the hashtable
 
         for kvp in code.Labels do
             dict.Add(kvp.Key, adjust[kvp.Value])

src/Compiler/Checking/AttributeChecking.fs

@@ -522,7 +522,7 @@ let CheckRecdFieldInfoAttributes g (x:RecdFieldInfo) m =
     CheckRecdFieldAttributes g x.RecdFieldRef m
 
 // Identify any security attributes
-let IsSecurityAttribute (g: TcGlobals) amap (casmap : Dictionary<Stamp, bool>) (Attrib(tcref, _, _, _, _, _, _)) m =
+let IsSecurityAttribute (g: TcGlobals) amap (casmap : IDictionary<Stamp, bool>) (Attrib(tcref, _, _, _, _, _, _)) m =
     // There's no CAS on Silverlight, so we have to be careful here
     match g.attrib_SecurityAttribute with
     | None -> false
@@ -533,7 +533,7 @@ let IsSecurityAttribute (g: TcGlobals) amap (casmap : Dictionary<Stamp, bool>) (
             match casmap.TryGetValue tcs with
             | true, c -> c
             | _ ->
-                let exists = ExistsInEntireHierarchyOfType (fun t -> typeEquiv g t (mkAppTy attr.TyconRef [])) g amap m AllowMultiIntfInstantiations.Yes (mkAppTy tcref [])
+                let exists = ExistsInEntireHierarchyOfType (fun t -> typeEquiv g t (mkAppTy attr.TyconRef [])) g amap m AllowMultiIntfInstantiations.Yes (mkAppTy tcref [])          
                 casmap[tcs] <- exists
                 exists
         | ValueNone -> false  

src/Compiler/Checking/AttributeChecking.fsi

@@ -96,7 +96,7 @@ val CheckValAttributes: g: TcGlobals -> x: ValRef -> m: range -> OperationResult
 val CheckRecdFieldInfoAttributes: g: TcGlobals -> x: RecdFieldInfo -> m: range -> OperationResult<unit>
 
 val IsSecurityAttribute:
-    g: TcGlobals -> amap: Import.ImportMap -> casmap: Dictionary<Stamp, bool> -> Attrib -> m: range -> bool
+    g: TcGlobals -> amap: Import.ImportMap -> casmap: IDictionary<Stamp, bool> -> Attrib -> m: range -> bool
 
 val IsSecurityCriticalAttribute: g: TcGlobals -> Attrib -> bool
 

src/Compiler/Checking/MethodCalls.fs

@@ -1806,9 +1806,9 @@ module ProvidedMethodCalls =
              expr: Tainted<ProvidedExpr>) = 
 
         let varConv =
-            // note: using paramVars.Length as assumed initial size, but this might not 
-            // be the optimal value; this wasn't checked before obsoleting Dictionary.ofList
-            let dict = Dictionary.newWithSize paramVars.Length
+            // note: Assuming the size based on paramVars
+            // Doubling to decrease chance of collisions
+            let dict = Dictionary.newWithSize (paramVars.Length*2)
             for v, e in Seq.zip (paramVars |> Seq.map (fun x -> x.PUntaint(id, m))) (Option.toList thisArg @ allArgs) do
                 dict.Add(v, (None, e))
             dict

src/Compiler/Checking/QuotationTranslator.fs

@@ -22,7 +22,7 @@ open System.Collections.Generic
 
 module QP = QuotationPickler
 
-let verboseCReflect = condition "VERBOSE_CREFLECT"
+let verboseCReflect = isEnvVarSet "VERBOSE_CREFLECT"
 
 [<RequireQualifiedAccess>]
 type IsReflectedDefinition =