Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing FSharp.Editor.Tests #14335

Merged
merged 9 commits into from
Nov 21, 2022
Merged

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Nov 16, 2022

closes #14314

A new clean project dedicated for unit testing FSharp.Editor:

  • No Salsa
  • No legacy dependencies
  • No weird file linking
  • No pesticides

This also brings a few extra changes on top of the mere moving of the files:

  • Turned on Fantomas hence formatting
  • Removed a bunch of unused code
  • Set proper namespaces in all files
  • Added MS copywrites in all files
  • Created FSharp.Editor.sln for light-weight work with the editor and its tests

What's beyond the scope:

  • Further cleanup of VisualFSharp.UnitTests (there is a lot of cleanup potential there)
  • Changing NUnit to xUnit
  • Consolidating type XTests vs module YTests in suites

All successfully runs locally in about 3 minutes:
image

@psfinaki psfinaki requested a review from a team as a code owner November 16, 2022 15:45
@TIHan
Copy link
Contributor

TIHan commented Nov 17, 2022

My goodness, this is great.

KevinRansom
KevinRansom previously approved these changes Nov 17, 2022
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add the new test project to build scripts, under the corresponding switches, and make sure they show up in CI

T-Gro
T-Gro previously approved these changes Nov 18, 2022
@psfinaki psfinaki dismissed stale reviews from T-Gro and KevinRansom via 28d8357 November 18, 2022 10:15
@psfinaki
Copy link
Member Author

Please, add the new test project to build scripts, under the corresponding switches, and make sure they show up in CI

Yep, all done, tests are running in CI:
image

@psfinaki psfinaki enabled auto-merge (squash) November 18, 2022 17:14
@psfinaki psfinaki merged commit 1160509 into dotnet:main Nov 21, 2022
@psfinaki psfinaki deleted the psfinaki/editor-tests-2 branch November 21, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Split F# editor tests
5 participants