No errors for non-virtual members overrides

[edgarfgp]

Fixes #11456

Reuses error 855, tcNoMemberFoundForOverride,"No abstract or interface member was found that corresponds to this override" for consistency.

But a clearer message would be
'C.M2': cannot override inherited member 'B.M2' because it is not marked virtual, abstract, or override."

• This will need to be a new error message
• Virtual is not used in F# and in this case refers to C#. So might be confusing
• It will require some string manipulation to get the type name, member name from the declaring type and the inherited type

[vzarytovskii]

Nice, thanks. If this was compiling before, this will need to go under language version flag.

[edgarfgp]

@vzarytovskii Any idea why the CI is failing with error FS0073: (NETCORE_ENGINEERING_TELEMETRY=Build) internal error: not a .NET type definition (Failure)

I will add a preview language flag

[vzarytovskii]

@vzarytovskii Vlad Zarytovskii FTE Any idea why the CI is failing with error FS0073: (NETCORE_ENGINEERING_TELEMETRY=Build) internal error: not a .NET type definition (Failure)

Erm, never seen it before, let me look if it's related to changes.

[vzarytovskii]

So, the error thrown in the Proto compiler, so it's likely related to the change:

/// Get the Abstract IL scope, nesting and metadata for this 
/// type definition, assuming it is backed by Abstract IL metadata.
member x.ILTyconInfo = match x.TypeReprInfo with | TILObjectRepr data -> data | _ -> failwith "not a .NET type definition"

[edgarfgp]

So, the error thrown in the Proto compiler, so it's likely related to the change:

/// Get the Abstract IL scope, nesting and metadata for this 
/// type definition, assuming it is backed by Abstract IL metadata.
member x.ILTyconInfo = match x.TypeReprInfo with | TILObjectRepr data -> data | _ -> failwith "not a .NET type definition"

Thanks, will look into it.

[edgarfgp]

@vzarytovskii it is green now 😀