Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Break in VS on coreclr and desktop #14218

Merged
merged 9 commits into from
Nov 7, 2022
Merged

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Nov 2, 2022

Enable Ctrl+Break to operate on VS FSI window in Visual Studio.

For Ctrl+Break has recently been implementing on the coreclr implementation of F# Interactive. This updates FCS/FSI and VS to enable it to operate within Visual Studio.

Fixes: 14063

Dotnet sdk FSI:
vsctrlbreak-dotnetsdk

Desktop FSI:
vsctrlbreak-desktop

@KevinRansom KevinRansom requested a review from a team as a code owner November 2, 2022 20:06
T-Gro
T-Gro previously approved these changes Nov 3, 2022
0101
0101 previously approved these changes Nov 3, 2022
src/Compiler/Interactive/FSharpInteractiveServer.fs Outdated Show resolved Hide resolved
@KevinRansom KevinRansom dismissed stale reviews from 0101 and T-Gro via 90e98aa November 3, 2022 22:24
0101
0101 previously approved these changes Nov 4, 2022
T-Gro
T-Gro previously approved these changes Nov 4, 2022
@KevinRansom KevinRansom dismissed stale reviews from T-Gro and 0101 via f2b84d9 November 4, 2022 19:20
@0101 0101 merged commit e381e35 into dotnet:main Nov 7, 2022
@KevinRansom KevinRansom deleted the vsinterrupt branch April 29, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+C or Ctrl+Break for fsi in visual studio when using dotnet fsi
4 participants