Prevent dotnet process spawn on compiler startup
#13969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vzarytovskii This is ready |
|
Longer term it might be nice if the SDK surfaced some way of resolving named Frameworks from the current install location via a NuGet package. We already ship resolvers for finding installed and usable SDKs, and I think the next step of "give me framework X from SDK Y" would enable use cases for scripting (like |
|
@vzarytovskii @KevinRansom ping :) |
vzarytovskii
approved these changes
Sep 27, 2022
T-Gro
approved these changes
Oct 6, 2022
|
@KevinRansom can you please take a look at it? |
KevinRansom
approved these changes
Oct 6, 2022
abonie
pushed a commit
to abonie/fsharp
that referenced
this pull request
Oct 7, 2022
* don't start process to determine system assemblies * code format * fix build break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13960
@vzarytovskii I think searching for
"Microsoft.NETCore.App.Ref"in the directory name is adequate for now.I did a performance comparison and on my laptop running:
Before: 2.9s
After: 2.7s
The proportional effect is greater if crossgen is active and you can actually measure the effect in the SDK today, as the process spawn only kicks in if non-default assemblies are referenced, e.g.
Make an
out.argsfor a simple project referencingNewtonsoft.Jsondotnet "\Program Files\dotnet\sdk\7.0.100-rc.1.22431.12\FSharp\fsc.dll" @out.args --timesThen remove this reference from the list and repeat
Before: consistently 1.7s
After: consistently 1.5s