Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing xml doc for member getset #13841

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 5, 2022

Related to #13833.
@auduchinok can you give an example where the XML doc is missing?

@auduchinok
Copy link
Member

@nojaf Sorry, I found an issue in our handling of the new GetSetMember, the XmlDoc is fine.

@dsyme
Copy link
Contributor

dsyme commented Sep 8, 2022

@nojaf I presume we still want this merged? LGTM

@nojaf
Copy link
Contributor Author

nojaf commented Sep 9, 2022

@dsyme yes please, I believe this is still valuable.

@vzarytovskii vzarytovskii enabled auto-merge (squash) September 15, 2022 10:02
auto-merge was automatically disabled September 26, 2022 06:09

Head branch was pushed to by a user without write access

@nojaf nojaf force-pushed the missing-xml-doc-for-member-getset branch from d3bf71c to 4ce5e5e Compare September 26, 2022 06:09
@nojaf nojaf force-pushed the missing-xml-doc-for-member-getset branch from 63175b3 to 4296743 Compare October 2, 2022 07:33
@vzarytovskii vzarytovskii merged commit ffdfc71 into dotnet:main Oct 6, 2022
@nojaf nojaf deleted the missing-xml-doc-for-member-getset branch October 6, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants