-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analysis of conjunctive patterns for exhaustiveness #13020
Conversation
Improving the pattern matching in conjunction with AP would be really nice . I have hit some of above limitation, making hard to grasp for a newcomer |
This probably needs a bunch of tests, from the linked issues. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
I did add some unites locally and it seems that only the second issue on the list is fixed. Happy to raise a PR to Don's fork with the unit tests :) |
@edgarfgp Thank you so much for checking! I've checked too and it seems both are fixed - with the first issue, two warnings were being generated - one for incomplete matching, and one for "never matched". The second is correct to emit, the first is not. I've added testing for both test cases. |
@vzarytovskii This is ready |
@dsyme Thanks for fixing this . I use AP and this will make the experience much better |
@vzarytovskii This seems to be ready and the CI timed out. Would be awesome to have this in :) |
The analysis of conjunctive patterns
pat & pat
has problems.This fixes these issues