-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More descriptive error message for diagnostic 727 #12832
More descriptive error message for diagnostic 727 #12832
Conversation
7523278
to
fa01817
Compare
This is amazing, and is related to #1103 if we are going to adjust the error message as well. |
@baronfel , can I help with finalizing this? To be honest, I do not think this should render "Item2" in the message if the argument is not named - would rather fallback to the type instead. Having said that, I would be happy to pick this up from you if you agree. |
Absolutely! To be honest I forgot that I submitted this PR, and I'd love someone to pick up the torch. |
Preventing display of generated Item2,.. names for DU field names Displaying type of field as part of the error message.
Will fill in later, my local build isn't working so I'm going to piggyback onto MS's CI :D
The gist is that this error is garbage:
We know the expected field names and the positions provided, so we can estimate names not provided and emit them here. The message can be changed to let the user know this is a suggestion, because DU cases can be added at any point. I'd argue that it's most likely to add them at the end, though.
The new error message is something like
because that at least gives the user a clue what kinds of fields/data they can expect (without having to rely on tooltips/go-to-definition for the DU)
Open questions: