Track the signaturehelp session kind in signature help #10970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One approach I tried before this was splitting each into a separate signature help provider. However, neither would get triggered by Roslyn when I did that. There may be a better solution to this with some changes added to Roslyn bindings. But that solution would also not be portable to an LSP implementation, forcing tools like FSAC/Ionide to effectively implement what I have done here. Might as well just do it the same way everywhere so that at least the different editors share their approach to this kind of stuff. |
TIHan
approved these changes
Jan 29, 2021
|
I think I feel pretty comfortable taking this in giving it another look. Will of course improve upon anything suboptimal. |
cartermp
added a commit
to cartermp/fsharp
that referenced
this pull request
Jan 29, 2021
KevinRansom
added a commit
that referenced
this pull request
Feb 1, 2021
Cherry Pick into 16.9 - Track the signaturehelp session kind in signature help (#10970)
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Cherry Pick into 16.9 - Track the signaturehelp session kind in signature help (dotnet#10970)
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was a little bit of a doozy.
Addresses the first issue mentioned in #10957
What this does is it tracks:
It then adjusts the state of the session based on what we're trying to do.
I'm not 100% confident in this PR yet. Will need to test it out some more. But it seems to do what I wanted to do, which is it keeps the tooltip up in both kinds of signature help sessions.