Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build FSI and FSC using AppHost #10736

Merged
merged 5 commits into from
Dec 21, 2020
Merged

Conversation

KevinRansom
Copy link
Member

Since the begining we have built the coreclr versions of fsc and fsi as il .exe files. The AppHost wasn't introduced at the beginning, and we were in a groove that worked for us.

This changes things so that we build them as fsi.dll and fsc.dll and produce apphost fsi.exe and fsc.exe.

this means that things like this work:

C:\Users\codec>c:\kevinransom\fsharp\artifacts\bin\fsi\Release\netcoreapp3.1\fsi.exe

Microsoft (R) F# Interactive version 11.0.0.0 for F# 5.0
Copyright (c) Microsoft Corporation. All Rights Reserved.

For help type #help;;

>  printfn "%s" typeof<int>.Assembly.Location;;
C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.1.10\System.Private.CoreLib.dll
val it : unit = ()

> #quit;;

C:\Users\codec>c:\kevinransom\fsharp\artifacts\bin\fsc\release\netcoreapp3.1\fsc.exe
Microsoft (R) F# Compiler version 11.0.0.0 for F# 5.0
Copyright (c) Microsoft Corporation. All Rights Reserved.

error FS0207: No inputs specified

C:\Users\codec>

It should be noted that even after this change, the only supported scenarios for using fsi is via dotnet fsi and fsc is via dotnet build. The apphost versions will make things a little easier in the repo, and tooling may be a bit easier to write.

@KevinRansom KevinRansom reopened this Dec 16, 2020
@KevinRansom KevinRansom reopened this Dec 16, 2020
@KevinRansom KevinRansom changed the title WIP: Build FSI and FSC using AppHost Build FSI and FSC using AppHost Dec 17, 2020
@vzarytovskii vzarytovskii merged commit 80e3d68 into dotnet:main Dec 21, 2020
@dsyme
Copy link
Contributor

dsyme commented Dec 22, 2020

Something is causing the proto compiler to be continually rebuilt on every

 .\build

when the compiler files have changed. Could it be this or another recent PR?

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* move over to fsc.dll and fsi.dll
@KevinRansom KevinRansom deleted the renamecompilers branch January 21, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants