-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser: add recovery for missing fields after 'of' in union case #10708
Conversation
0dbaf1c
to
5be4216
Compare
There's some tests failure, but tests got broken again, so I can't debug it: #10719 |
FCS tests pass, this one is an annoying timeout based one that seems to fail from time to time:
So restarting the PR or pushing a new change will probably have it resolve. fsharpqa test failure looks like it's just a bad expectation, changing this: Line 7 in d76f5ac
to this: - span="(10,12-11,1)"
+ span="(10,12-12,24)" should fix it I think. The fsharpqa logs at least show that this was the range reported with your PR, which looks more accurate. |
grr, that should have done it. This is the failure log from CI:
Does that imply that the warning was given twice or something? I don't know how to read this (cc @KevinRansom @dsyme) |
OK, let's see if it helps (though, it's not expected indeed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the one that actually does it if I'm reading the log correctly.
Although it's strange that we would get two diagnostics.
...rpqa/Source/Conformance/BasicTypeAndModuleDefinitions/UnionTypes/W_UnionCaseProduction01.fsx
Outdated
Show resolved
Hide resolved
…s/UnionTypes/W_UnionCaseProduction01.fsx Co-authored-by: Phillip Carter <[email protected]>
…net#10708) * Parser: add recovery for missing fields after 'of' in union case * Remove redundant opt_OBLOCKSEP * Recover in exceptions too * Fix test * Update test baseline * Add second warning * Update tests/fsharpqa/Source/Conformance/BasicTypeAndModuleDefinitions/UnionTypes/W_UnionCaseProduction01.fsx Co-authored-by: Phillip Carter <[email protected]> Co-authored-by: Phillip Carter <[email protected]>
Fixes parsing and subsequent analysis for unfinished union cases and exceptions like
Before:
After: