Finish adding signature files to src/fsharp #10692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TIHan @KevinRansom @vzarytovskii @cartermp Can one of you approve? Let's just get this in - and I'll need to integrate this with feature/nullness and others |
cartermp
approved these changes
Dec 12, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Co-authored-by: Don Syme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more or less completes the addition of signature files to src\fsharp
The signature files were based on auto-generation via "--sig" option and then hand adjustment, copying the comments across and removing some unused items
The only major files missing signature files are TypedTree.fs and SyntaxTree.fs. Those are last due to the very high rate of duplication, though realistically we'll need signature files for those too due to the need to pin down and reduce the public surface are of FSharp.Compiler.Service.dll