FSharpQA tests migration to xUnit suite - Part 1/? #10669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some helper functions to test framework.
|
Is there any automatic way to update all IL baselines after a change that affects multiple ones? Currently I use |
Good question, I don't think it's currently easily possible in the new framework. You can delete baseline files, and they will be re-generated, however with different extension. |
|
I don't automatically do it, so that I can at least eyeball the changes. |
KevinRansom
approved these changes
Dec 16, 2020
cartermp
approved these changes
Dec 16, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Fixed a bunch of lst files (fixed Expect -> Expects), casing. Added some helper functions to test framework. * Fxied missing imports in test framework * Fixed double quotes around compiler flags in lst file * Fixed double quotes around compiler flags in lst file * Migrated a bunch of fsharpqa tests, simpler ones, which do not require run, il * Removed already migrated tests from fsharpqa env.lst * Fix some post-migration issues * Reverted back some fsharpqa changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (semi-)automatic migration of F#QA tests to xUnit suite.
This is pretty much second try of #10415, in previous one, remaining fshsarpqa tests weren't discovered by runner. In this PR, we don't modify tests.lst much.
This PR is migrating only small fraction of simpler tests, which do not require running, IL comparison, or linking other libs - to test the migration script.
After this one is passing, I will start migrating other batches.