Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCS testing and fix for witnesses for unit of measure code #10668

Merged
merged 5 commits into from
Dec 10, 2020

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Dec 10, 2020

While integrating main with #6805 I came across a case where unit of measure code wasn't giving witnesses properly in FCS FSharpExpr

This fixes the problem and adds some testing.

@cartermp cartermp added this to the 16.9 milestone Dec 10, 2020
@dsyme
Copy link
Contributor Author

dsyme commented Dec 10, 2020

This is ready

@dsyme dsyme changed the title Testing and fix for witnesses for unit of measure code FCS testing and fix for witnesses for unit of measure code Dec 10, 2020
@TIHan TIHan merged commit 540ad0d into dotnet:main Dec 10, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
)

* add expression testing for unitized operators

* fix witnesses for primitive operators with units of measure

* first check test cases fail for primitive operators with units of measure

* fix witnesses for primitive operators with units of measure

* fix witnesses

Co-authored-by: Don Syme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants