Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MakeOuterBindingRecursive code fix #10666

Merged
merged 7 commits into from
Dec 16, 2020

Conversation

cartermp
Copy link
Contributor

Because I do this a lot, here's a code fix to make me more productive.

Basic case:

image

Nested case:

image

Note that it does NOT trigger on g here, since g is truly undefined:

image

Recursive needed for value case (nameof):

image

@cartermp
Copy link
Contributor Author

This is now ready for review

@TIHan TIHan merged commit 9fdb46b into dotnet:main Dec 16, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Add MakeOuterBindingRecursive code fix

* Allow other bindings to come before a nested should-be-recursive binding

* more fixy

* formatting and comment

* Add to service layer

* Area and add name to message
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
* Add MakeOuterBindingRecursive code fix

* Allow other bindings to come before a nested should-be-recursive binding

* more fixy

* formatting and comment

* Add to service layer

* Area and add name to message
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
* Add MakeOuterBindingRecursive code fix

* Allow other bindings to come before a nested should-be-recursive binding

* more fixy

* formatting and comment

* Add to service layer

* Area and add name to message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants