Make FSharp.Build build netstandard2.0 #10626
Conversation
KevinRansom
force-pushed
the
makefsharpbuildnetstandard
branch
from
5e9e385 to
8fbaa10
Compare
| @@ -6,9 +6,6 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Projects Include="src\fsharp\FSharp.Build\FSharp.Build.fsproj"> | |||
| <AdditionalProperties Condition="'$(OS)' == 'Unix'">TargetFramework=netcoreapp3.1</AdditionalProperties> | |||
| </Projects> | |||
| <Projects Include="src\fsharp\fsc\fsc.fsproj"> | |||
| <AdditionalProperties Condition="'$(OS)' == 'Unix'">TargetFramework=netcoreapp3.1</AdditionalProperties> | |||
There was a problem hiding this comment.
can this now be moved to the upper property group unconditionally?
There was a problem hiding this comment.
hmm, this is proto.proj, was this intended?
KevinRansom
force-pushed
the
makefsharpbuildnetstandard
branch
from
8fbaa10 to
285c2c7
Compare
| <TargetFrameworks Condition="'$(ProtoTargetFramework)' == ''">net472;netcoreapp3.1</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(OS)' == 'Unix'">netcoreapp3.1</TargetFrameworks> | ||
| <TargetFramework Condition="'$(Configuration)' != 'Proto'">netstandard2.0</TargetFramework> | ||
| <TargetFrameworks Condition="'$(Configuration)' == 'Proto'">netstandard2.0</TargetFrameworks> |
There was a problem hiding this comment.
These should be collapsed into a single <TargetFramework>netstandard2.0</TargetFramework>.
There was a problem hiding this comment.
@brettfo , yeah ... no. We publish and publish requires either a single tfm or a specified framework, I couldn't figure out how to specify a framework on the unix build.
A single tfm in the product build fails with missing tfms. I wasted days trying to figure out something that would actually work. But we can get together and you can experience the frustration of it if you would like,
| <PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkVersion)" /> | ||
| <PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" /> | ||
| <PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCoreVersion)" /> | ||
| <PackageReference Include="Microsoft.Build" Version="$(MicrosoftBuildFrameworkVersion)" PrivateAssets="all" /> |
There was a problem hiding this comment.
Keep the package name and variable name in sync.
| @@ -17,7 +17,7 @@ | |||
| <AdditionalProperties>TargetFramework=netcoreapp3.1</AdditionalProperties> | |||
| </ProjectReference> | |||
| <ProjectReference Include="..\FSharp.Build\FSharp.Build.fsproj"> | |||
| <AdditionalProperties>TargetFramework=netcoreapp3.1</AdditionalProperties> | |||
| <AdditionalProperties>TargetFramework=netstandard2.0</AdditionalProperties> | |||
There was a problem hiding this comment.
If the TFM of FSharp.Build is only netstandard2.0, this shouldn't be necessary.
There was a problem hiding this comment.
Yeah you would think .... however ... the proto project is a bit wierder than it looks, like above we can get together and you can experience the wierdness if you like.
| @@ -5,7 +5,6 @@ | |||
| <PropertyGroup> | |||
| <OutputType>Library</OutputType> | |||
| <TargetFrameworks>net472;netstandard2.0</TargetFrameworks> | |||
| <TargetFrameworks Condition="'$(OS)' == 'Unix'">netstandard2.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Doesn't this cause it to fail on mac/linux?
There was a problem hiding this comment.
it was a mistake, I need to revert it.
There was a problem hiding this comment.
Although no, it doesn't and I don't really understand why.
There was a problem hiding this comment.
@brettfo, you can build net472 on linux. You can't run it, but you can for sure build it.
|
Thanks brett, I appreciate it. I wish our build were simpler. |
* Make FSharp.Build build netstandard2.0 * typo * fixes * temp * display environment windows * feedback * test fails
There is no good reason for not building this netstandard2.0.
So making it happen.