Don't lift the result of getting a symbol use in the add open code fix #10594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Dec 7, 2020
ScottHutchinson
pushed a commit
to ScottHutchinson/fsharp
that referenced
this pull request
Dec 8, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10533
This commit broke the code fixer: 3b294c4
Before, the call was asynchronous and so we lifted that into an option. It's no longer asynchronous, but the code compiled because
asymcMaybecan also work with options. So the code was now lifting the result into an option, creating aSome(None)as the result. Because we assert that there is no symbol use, the code fixer would fail becauseSome(None)matches false forIsNone.This removes the call to
liftAsync, and also changes the CE tomaybebecause nothing is asynchronous.