Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build net472 of Microsoft.DotNet.DependencyMangager since the netstandard2.0 can't be ngened #10390

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Nov 5, 2020

Because Microsoft.DotNet.DependencyManager depends on System.Runtime.Loader in netstandard2.0, it can't be ngened and FSharp.Compiler.Private has a reference to MS.DN.DM which will always pull it into the ngen graph.

Eventually this will be corrected (@KevinRansom and I had a terrifying talk), but for now we still need net472.

Confirmed this passes ngen.

@brettfo brettfo merged commit 280a6a3 into dotnet:main Nov 5, 2020
@brettfo brettfo deleted the ngen branch November 5, 2020 22:01
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant