-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing reactor-queue dependencies #10292
Conversation
@TIHan as expected/discussed, one legacy test that relied on the "hasTextChangedSinceLastTypecheck" in the old language service no longer passes, I've simply removed the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting up a block for the other PRs to be merged
@TIHan conflicts need to be resolved |
I've done this now. Might need to patch up some argument names |
As part of 10292 we will do all of these:
Get*UsesOfAllSymbolsIn*
were only async to support cancellation. For clarity these will no no longer by async and instead accept an optional cancellation tokenuserOpName
is removed from all the operations which are no longer async (it is there for async causality tracing)StructuredDescriptionTextAsync
andDescriptionTextAsync
no longer used the Reactor thread. They are marked as obsolete, and instead synchronousStructuredDescriptionText
andDescriptionText
should be usedscriptClosureCache
andincrementalBuildersCache
are now usable from any threadhasTextChangedSinceLastTypecheck
is removed from FSharpChecker API as it no longer needed by Visual F# Tools since 2017 rewritetextSnapshotInfo
is removed from FSharpChecker API as it only existed to pass back tohasTextChangedSinceLastTypecheck