Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing reactor-queue dependencies #10292

Merged
merged 18 commits into from
Oct 28, 2020
Merged

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Oct 20, 2020

As part of 10292 we will do all of these:

  • All of the FSharpCheckFileResults operations will no longer use the Reactor and hence no longer by async.
  • The four operations Get*UsesOfAllSymbolsIn* were only async to support cancellation. For clarity these will no no longer by async and instead accept an optional cancellation token
  • userOpName is removed from all the operations which are no longer async (it is there for async causality tracing)
  • StructuredDescriptionTextAsync and DescriptionTextAsync no longer used the Reactor thread. They are marked as obsolete, and instead synchronous StructuredDescriptionText and DescriptionText should be used
  • The caches scriptClosureCache and incrementalBuildersCache are now usable from any thread
  • The optional argument hasTextChangedSinceLastTypecheck is removed from FSharpChecker API as it no longer needed by Visual F# Tools since 2017 rewrite
  • The optional argument textSnapshotInfo is removed from FSharpChecker API as it only existed to pass back to hasTextChangedSinceLastTypecheck
  • Allows the IncrementalBuilder cache to be used on any thread. This is some minor preliminary work that needs to be done in order to make FCS less reactor-queue dependent.

@TIHan TIHan changed the title Allowing IncrementalBuilder cache to be used on any thread [WIP] Removing reactor-queue dependent FCS calls Oct 22, 2020
@dsyme dsyme changed the title [WIP] Removing reactor-queue dependent FCS calls [WIP] Removing reactor-queue dependencies Oct 22, 2020
@dsyme
Copy link
Contributor

dsyme commented Oct 22, 2020

@TIHan as expected/discussed, one legacy test that relied on the "hasTextChangedSinceLastTypecheck" in the old language service no longer passes, I've simply removed the test

@TIHan TIHan changed the title [WIP] Removing reactor-queue dependencies Removing reactor-queue dependencies Oct 22, 2020
@TIHan
Copy link
Contributor Author

TIHan commented Oct 22, 2020

Before we merge, we need to merge these first: #10310 and #10308
Those PRs, while isolated, are necessary to ensure safety.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting up a block for the other PRs to be merged

@dsyme
Copy link
Contributor

dsyme commented Oct 27, 2020

@TIHan conflicts need to be resolved

@dsyme
Copy link
Contributor

dsyme commented Oct 27, 2020

@TIHan conflicts need to be resolved

I've done this now. Might need to patch up some argument names

@dsyme
Copy link
Contributor

dsyme commented Oct 27, 2020

Before we merge, we need to merge these first: #10310 and #10308. Those PRs, while isolated, are necessary to ensure safety.

These have now been merged and integrated with this PR.

@dsyme dsyme merged commit 07e12af into dotnet:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants