Able to remap DecisionTreeTest.Error #10187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Do you think it makes sense to have all "external" or "blackbox-style" tests in the ComponentTests suite?
At least new ones?
My reasoning is that if you test compiler "from outside", as a blackbox, then it makes more sense to have it in component tests.
If you testing some functions/library code - it's unit tests suite.
What do you think?
|
@TIHan Thank you for looking into it! |
|
@vzarytovskii I think moving it to component tests make sense. |
cartermp
approved these changes
Sep 26, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9296
I think the best way to resolve this was to just to allow
DecisionTreeTest.Errorto be remapped. Other parts of compilation checks for it so it should be safe.