Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const keyword to completion info #10158

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Add const keyword to completion info #10158

merged 1 commit into from
Sep 20, 2020

Conversation

DedSec256
Copy link
Contributor

@DedSec256 DedSec256 commented Sep 19, 2020 •
edited
Loading

  • Added const keyword to completion info

@DedSec256 DedSec256 force-pushed the ber.a/constKeyword branch 2 times, most recently from f17dc4a to 33b50a2 Compare September 20, 2020 00:37
@DedSec256
Copy link
Contributor Author

Can you help with the wording of the description text?

@cartermp
Copy link
Contributor

The description text is good. Thanks!

@auduchinok
Copy link
Member

It seems localization files would need an update? What's the proper process of handling this?

@cartermp
Copy link
Contributor

These get handled by a localization team leading up to every VS and .NET release. Every once in a while they come back with questions about certain terms but it's usually automatic from our perspective.

@cartermp
Copy link
Contributor

I think it's possible to add a custom localization though, if that's preferred.

@cartermp cartermp merged commit 3ef7e23 into dotnet:main Sep 20, 2020
@DedSec256 DedSec256 deleted the ber.a/constKeyword branch September 21, 2020 00:20
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@DedSec256 @nosami
Add const keyword to completion info (dotnet#10158)
cfd23b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DedSec256 @cartermp @auduchinok @KevinRansom