Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 9903 - FS0192 "destRefTupleTy: not a reference tuple type" #10074

Merged
merged 3 commits into from
Sep 6, 2020
Merged

Fix 9903 - FS0192 "destRefTupleTy: not a reference tuple type" #10074

merged 3 commits into from
Sep 6, 2020

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Sep 4, 2020

Fix 9903

#9903

@dsyme
Copy link
Contributor Author

dsyme commented Sep 4, 2020

This is ready (once green)

@dsyme
Copy link
Contributor Author

dsyme commented Sep 4, 2020

Strange build failure, cc @brettfo - I can't see why the assemblies would rebuild here

##[error](NETCORE_ENGINEERING_TELEMETRY=Test) 6 of 3489 assemblies were re-compiled.
    D:\a\1\s\artifacts\bin\FSharp.Compiler.UnitTests\Release\net472\CSharp_Analysis.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.Service.Tests\Release\net472\CSharp_Analysis.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.UnitTests\Release\netcoreapp3.1\FSharp.Compiler.UnitTests.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.Service.Tests\Release\net472\FSharp.Compiler.Service.Tests.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.UnitTests\Release\netcoreapp3.1\CSharp_Analysis.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.UnitTests\Release\net472\FSharp.Compiler.UnitTests.dll
##[error]PowerShell exited with code '1'.
Finishing: Run up-to-date build check
Task Insights

This task has failed 23 times across 154 pipeline runs in the last 14 days.

View Report
Copy permalink

@cartermp
Copy link
Contributor

cartermp commented Sep 4, 2020

also cc @KevinRansom - I noticed this in the signed build as well.

@cartermp cartermp closed this Sep 4, 2020
@cartermp cartermp reopened this Sep 4, 2020
@cartermp cartermp closed this Sep 5, 2020
@cartermp cartermp reopened this Sep 5, 2020
@cartermp
Copy link
Contributor

cartermp commented Sep 5, 2020

Geez our CI is running like absolute crap right now :(

Unhandled Exception: System.IO.FileNotFoundException: Could not find file 'D:\a\1\s\tests\fsharp\typecheck\sigs\pos38.dll'.

@cartermp cartermp closed this Sep 5, 2020
@cartermp cartermp reopened this Sep 5, 2020
@cartermp
Copy link
Contributor

cartermp commented Sep 5, 2020

Aaaand CI isn't even triggered. Lovely.

@cartermp cartermp linked an issue Sep 6, 2020 that may be closed by this pull request
FS0192 "destRefTupleTy: not a reference tuple type" #9903
Closed
@dsyme
Copy link
Contributor Author

dsyme commented Sep 6, 2020

Geez our CI is running like absolute crap right now :(

Unhandled Exception: System.IO.FileNotFoundException: Could not find file 'D:\a\1\s\tests\fsharp\typecheck\sigs\pos38.dll'.

This is a problem with the PR, don't blame the CI for this one :-)

@cartermp
Copy link
Contributor

cartermp commented Sep 6, 2020

aha!

@cartermp
Copy link
Contributor

cartermp commented Sep 6, 2020

It's funny how this doesn't trigger in sharplab, but does via a dotnet build command.

@cartermp cartermp merged commit 2bfdb79 into dotnet:main Sep 6, 2020
@fsouza fsouza mentioned this pull request Sep 19, 2020
Closed
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@dsyme @nosami
Fix 9903 - FS0192 "destRefTupleTy: not a reference tuple type" (dotne…
ad7da03 
…t#10074)

* fix 9903

* fix 9903

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FS0192 "destRefTupleTy: not a reference tuple type"
2 participants
@dsyme @cartermp